Remove the distance property

Author: D8H

extensions/reviewed/SpotLight3D.json

@@ -41,7 +41,7 @@
             "}",
             "",
             "/**",
-            " * @typedef {gdjs.RuntimeObject & {__cameraDistance: number, __spotLight: THREE.SpotLight, _getIsCastingShadow: () => boolean}} SpotLightRuntimeObject",
+            " * @typedef {gdjs.CustomRuntimeObject3D & {__cameraDistance: number, __spotLight: THREE.SpotLight, _getIsCastingShadow: () => boolean, _getConeAngle: () => number, _getColor: () => string}} SpotLightRuntimeObject",
             " */",
             "",
             "const game = runtimeScene.getGame();",
@@ -59,9 +59,9 @@
             "    }",
             "",
             "    _updateThreeGroup() {",
-            "        const object = this._object;",
-            "        /** @type {THREE.SpotLight} */",
+            "        /** @type {SpotLightRuntimeObject} */",
             "        //@ts-ignore",
+            "        const object = this._object;",
             "        const threeObject3D = this.get3DRendererObject();",
             "",
             "        threeObject3D.rotation.set(",
@@ -85,8 +85,6 @@
             "",
             "        threeObject3D.visible = !this._object.hidden;",
             "",
-            "        /** @type {THREE.SpotLight} */",
-            "        //@ts-ignore",
             "        const spotLight = object.__spotLight;",
             "",
             "        const editor = game.getInGameEditor ? game.getInGameEditor() : null;",
@@ -129,16 +127,10 @@
             "                const deltaZ = rootObject.getZ() - cameraZ;",
             "                distanceSq = deltaX * deltaX + deltaY * deltaY + deltaZ * deltaZ;",
             "            }",
-            "            //@ts-ignore",
-            "            const distanceMax = object._getVisibilityDistanceMax();",
-            "            const isWithInRange = distanceSq <= distanceMax * distanceMax;",
-            "            if (isWithInRange) {",
-            "                getSpotLightManager(",
-            "                    //@ts-ignore",
-            "                    runtimeScene",
-            "                ).applyVisibilityAndShadow(object, distanceSq);",
-            "            }",
-            "",
+            "            getSpotLightManager(",
+            "                //@ts-ignore",
+            "                runtimeScene",
+            "            ).applyVisibilityAndShadow(object, distanceSq);",
             "        }",
             "",
             "        // Force the visibility to be checked every frame",
@@ -263,17 +255,17 @@
             "const coneLength = 64;",
             "",
             "class SpotLightHelper extends THREE.Object3D {",
-            "    /** @type {gdjs.CustomRuntimeObject3D} */",
+            "    /** @type {SpotLightRuntimeObject} */",
             "    object;",
-            "    /** @type {THREE.LineSegments} */",
+            "    /** @type {THREE.LineSegments<THREE.BufferGeometry, THREE.LineBasicMaterial>} */",
             "    cone;",
-            "    /** @type {THREE.LineSegments} */",
+            "    /** @type {THREE.LineSegments<THREE.BufferGeometry, THREE.LineBasicMaterial>} */",
             "    centerLine;",
-            "    /** @type {THREE.Mesh} */",
+            "    /** @type {THREE.Mesh<THREE.BoxGeometry, THREE.MeshBasicMaterial>} */",
             "    originBox;",
             "",
             "\t/**",
-            "     * @param {gdjs.CustomRuntimeObject3D} object",
+            "     * @param {SpotLightRuntimeObject} object",
             "\t */",
             "    constructor(object) {",
             "        super();",
@@ -325,38 +317,23 @@
             "",
             "    dispose() {",
             "        this.cone.geometry.dispose();",
-            "        //@ts-ignore",
             "        this.cone.material.dispose();",
             "        this.centerLine.geometry.dispose();",
-            "        //@ts-ignore",
             "        this.centerLine.material.dispose();",
             "        this.originBox.geometry.dispose();",
-            "        //@ts-ignore",
             "        this.originBox.material.dispose();",
             "    }",
             "",
             "    update() {",
             "        /** @type {number} */",
-            "        //@ts-ignore",
             "        const coneAngle = gdjs.toRad(this.object._getConeAngle());",
             "        const coneWidth = coneLength * Math.sin(coneAngle);",
             "        const coneHeight = coneLength * Math.cos(coneAngle);",
             "        this.cone.scale.set(coneHeight, coneWidth, coneWidth);",
-            "        /** @type {number} */",
-            "        //@ts-ignore",
-            "        const color = gdjs.rgbOrHexStringToNumber(this.object._getColor())",
-            "        /** @type {THREE.LineBasicMaterial} */",
-            "        //@ts-ignore",
-            "        const coneMaterial = this.cone.material;",
-            "        coneMaterial.color.set(color);",
-            "        /** @type {THREE.LineBasicMaterial} */",
-            "        //@ts-ignore",
-            "        const centerLineMaterial = this.centerLine.material;",
-            "        centerLineMaterial.color.set(color);",
-            "        /** @type {THREE.MeshBasicMaterial} */",
-            "        //@ts-ignore",
-            "        const originBoxMaterial = this.originBox.material;",
-            "        originBoxMaterial.color.set(color);",
+            "        const color = gdjs.rgbOrHexStringToNumber(this.object._getColor());",
+            "        this.cone.material.color.set(color);",
+            "        this.centerLine.material.color.set(color);",
+            "        this.originBox.material.color.set(color);",
             "    }",
             "}",
             "",
@@ -2119,12 +2096,6 @@
           "group": "Shadow",
           "name": "IsCastingShadow"
         },
-        {
-          "value": "2000",
-          "type": "Number",
-          "label": "Visibility distance",
-          "name": "VisibilityDistanceMax"
-        },
         {
           "value": "Medium",
           "type": "Choice",
@@ -2177,9 +2148,6 @@
           {
             "propertyName": "Decay"
           },
-          {
-            "propertyName": "VisibilityDistanceMax"
-          },
           {
             "folderName": "Cone",
             "children": [