BDM Resonant Scattering#471
Open
ZWorr wants to merge 350 commits into
Open
Conversation
added 30 commits
February 16, 2024 16:43
Splines for BDM models
Removed description of fork
remove 'AllNeutrino'
nusense
approved these changes
May 8, 2026
Member
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
This set of changes, unless I'm reading GitHub's differences since last review, doesn't seem to have addressed all the previous comments. In particular the param_sets DMRESv0 and DMRESv2 that duplicate DMRES in config/EventGenerator.xml.
I think it would be nice to see the is_dmdis renamed, as it is now DIS + RES, because I don't like misleading variable names -- this is in Framework/Interaction/KPhaseSpace.cxx
replaced is_dmdis with is_dminel
Removed DMRESv0 and DMRESv2 comments
Member
|
Latest changes resolved my remaining comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Resonant scattering to the Boosted Dark Matter physics module. Modified the framework to include Boosted Dark Matter Resonant Scattering.