Skip to content

when cloning a particle set LastMother to -1 in case source had two mothers#489

Open
nusense wants to merge 3 commits into
GENIE-MC:masterfrom
nusense:rhatcher/fix_mother_anomalies
Open

when cloning a particle set LastMother to -1 in case source had two mothers#489
nusense wants to merge 3 commits into
GENIE-MC:masterfrom
nusense:rhatcher/fix_mother_anomalies

Conversation

@nusense
Copy link
Copy Markdown
Member

@nusense nusense commented May 13, 2026

do this at the same point where FirstMother is set to the original particle

Copy link
Copy Markdown
Member

@sjgardiner sjgardiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @nusense, just a couple of questions for you.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you understand the intended behavior of the int mom argument here? This seems unique to hN. All non-hN revisions look fine.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the other place that's questionable, for the same reason.

@nusense
Copy link
Copy Markdown
Member Author

nusense commented May 15, 2026

From slack discussion:
@sjgardiner All looks good, except I don't understand the hN recipe. What you have is probably OK there too, though.
@nusense
Hmm.  No I don't really understand the original logic of it.   I think what's happening is there's split in the functionality between the cloning of the particle and the actual filling out the new particle (passed into the method).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants