when cloning a particle set LastMother to -1 in case source had two mothers#489
Open
nusense wants to merge 3 commits into
Open
when cloning a particle set LastMother to -1 in case source had two mothers#489nusense wants to merge 3 commits into
nusense wants to merge 3 commits into
Conversation
sjgardiner
reviewed
May 13, 2026
Member
sjgardiner
left a comment
There was a problem hiding this comment.
Looks great @nusense, just a couple of questions for you.
Member
There was a problem hiding this comment.
Do you understand the intended behavior of the int mom argument here? This seems unique to hN. All non-hN revisions look fine.
Member
There was a problem hiding this comment.
This is the other place that's questionable, for the same reason.
Member
Author
|
From slack discussion: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do this at the same point where FirstMother is set to the original particle