Skip to content

when cloning a particle set LastMother to -1 in case source had two mothers #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nusense wants to merge 3 commits into
base: master
Choose a base branch
from
Open

when cloning a particle set LastMother to -1 in case source had two mothers #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53e1669
when cloning a particle set LastMother to -1 in case source had two m…
nusense May 13, 2026
62c8077
undo erroneous change
nusense May 13, 2026
59951d0
overlooked one instance
nusense May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/HAIntranuke.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/*
Copyright (c) 2003-2025, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Author: Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ.
Aaron Meyer <asm58@pitt.edu>, Pittsburgh Univ.
Expand Down
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/HAIntranuke2018.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/*
Copyright (c) 2003-2025, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Author: Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ.
Aaron Meyer <asm58@pitt.edu>, Pittsburgh Univ.
Expand Down
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/HAIntranuke2025.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/*
Copyright (c) 2003-2025, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Author: Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ.
Aaron Meyer <asm58@pitt.edu>, Pittsburgh Univ.
Expand Down
2 changes: 2 additions & 0 deletions src/Physics/HadronTransport/HNIntranuke2018.cxx
View file
Open in desktop
Copy link
Copy Markdown
Member

@sjgardiner sjgardiner May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you understand the intended behavior of the int mom argument here? This seems unique to hN. All non-hN revisions look fine.

Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,7 @@ int HNIntranuke2018::HandleCompoundNucleus(GHepRecord* ev, GHepParticle* p, int
{
GHepParticle * sp = new GHepParticle(*p);
sp->SetFirstMother(mom);
sp->SetLastMother(-1); // in case mother had 2 mothers
// this was PreEquilibrium - now just used for hN
//same arguement lists for PreEq and Eq
utils::intranuke2018::Equilibrium(ev,sp,fRemnA,fRemnZ,fRemnP4,
Expand All @@ -935,6 +936,7 @@ int HNIntranuke2018::HandleCompoundNucleus(GHepRecord* ev, GHepParticle* p, int
<< "*** Nothing left to interact with, escaping.";
GHepParticle * sp = new GHepParticle(*p);
sp->SetFirstMother(mom);
sp->SetLastMother(-1);
sp->SetStatus(kIStStableFinalState);
ev->AddParticle(*sp);
delete sp;
Expand Down
2 changes: 2 additions & 0 deletions src/Physics/HadronTransport/HNIntranuke2025.cxx
View file
Open in desktop
Copy link
Copy Markdown
Member

@sjgardiner sjgardiner May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the other place that's questionable, for the same reason.

Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,7 @@ int HNIntranuke2025::HandleCompoundNucleus(GHepRecord* ev, GHepParticle* p, int
{
GHepParticle * sp = new GHepParticle(*p);
sp->SetFirstMother(mom);
sp->SetLastMother(-1); // in case mother had 2 mothers
// this was PreEquilibrium - now just used for hN
//same arguement lists for PreEq and Eq
utils::intranuke2025::Equilibrium(ev,sp,fRemnA,fRemnZ,fRemnP4,
Expand All @@ -932,6 +933,7 @@ int HNIntranuke2025::HandleCompoundNucleus(GHepRecord* ev, GHepParticle* p, int
<< "*** Nothing left to interact with, escaping.";
GHepParticle * sp = new GHepParticle(*p);
sp->SetFirstMother(mom);
sp->SetLastMother(-1); // in case mother had 2 mothers
sp->SetStatus(kIStStableFinalState);
ev->AddParticle(*sp);
delete sp;
Expand Down
1 change: 1 addition & 0 deletions src/Physics/HadronTransport/HadronTransporter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ void HadronTransporter::TransportInTransparentNuc(GHepRecord * evrec) const
GHepParticle * cp = new GHepParticle(*p); // create a clone

cp->SetFirstMother(icurr); // clone's mother
cp->SetLastMother(-1); // in case mother had 2 mothers
cp->SetStatus(kIStStableFinalState); // mark it & done with it

evrec->AddParticle(*cp); // add it at the event record
Expand Down
1 change: 1 addition & 0 deletions src/Physics/HadronTransport/INukeDeltaPropg.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ void INukeDeltaPropg::ProcessEventRecord(GHepRecord * event) const

// Set clone's mom to be the hadron that was cloned
sp->SetFirstMother(icurr);
sp->SetLastMother(-1); // in case mother had 2 mothers

// Start stepping particle out of the nucleus
bool has_interacted = false;
Expand Down
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/INukeException.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/*
Copyright (c) 2003-2025, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Costas Andreopoulos <c.andreopoulos \at cern.ch>
University of Liverpool
Expand Down
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/INukeHadroData.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/*
Copyright (c) 2003-2025, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Costas Andreopoulos <c.andreopoulos \at cern.ch>, Rutherford Lab.
Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ.
Expand Down
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/INukeHadroData2018.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/*
Copyright (c) 2003-2025, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Costas Andreopoulos <c.andreopoulos \at cern.ch>, Rutherford Lab.
Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ.
Expand Down
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/INukeHadroData2025.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/*
Copyright (c) 2003-2024, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Costas Andreopoulos <c.andreopoulos \at cern.ch>, Rutherford Lab.
Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ.
Expand Down
1 change: 0 additions & 1 deletion src/Physics/HadronTransport/INukeNucleonCorr.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
Copyright (c) 2003-2025, The GENIE Collaboration
For the full text of the license visit http://copyright.genie-mc.org


Author: Tomek Golan <tomasz.golan@uwr.edu.pl>, FNAL/Rochester
Steve Dytman <dytman+@pitt.edu>, Pittsburgh Univ.
Josh Kleckner <jok84@pitt.edu>, Pittsburgh Univ.
Expand Down
1 change: 1 addition & 0 deletions src/Physics/HadronTransport/INukeUtils.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,7 @@ void genie::utils::intranuke::PreEquilibrium(
// decay a clone particle
GHepParticle * t = new GHepParticle(*(ev->Particle(f_loc)));
t->SetFirstMother(f_loc);
t->SetLastMother(-1); // in case mother had 2 mothers
genie::utils::intranuke::Equilibrium(ev,t,RemnA,RemnZ,RemnP4,DoFermi,FermiFac,Nuclmodel,NucRmvE,mode);

delete t;
Expand Down
1 change: 1 addition & 0 deletions src/Physics/HadronTransport/INukeUtils2018.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,7 @@ void genie::utils::intranuke2018::PreEquilibrium(
// decay a clone particle
GHepParticle * t = new GHepParticle(*(ev->Particle(f_loc)));
t->SetFirstMother(f_loc);
t->SetLastMother(-1); // in case mother had 2 mothers
//next statement was in Alex Bell's original code - PreEq, then Equilibrium using particle with highest energy. Note it gets IST=kIStIntermediateState.
//genie::utils::intranuke2018::Equilibrium(ev,t,RemnA,RemnZ,RemnP4,DoFermi,FermiFac,Nuclmodel,NucRmvE,mode);

Expand Down
1 change: 1 addition & 0 deletions src/Physics/HadronTransport/INukeUtils2025.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,7 @@ void genie::utils::intranuke2025::PreEquilibrium(
// decay a clone particle
GHepParticle * t = new GHepParticle(*(ev->Particle(f_loc)));
t->SetFirstMother(f_loc);
t->SetLastMother(-1); // in case mother had 2 mothers
//next statement was in Alex Bell's original code - PreEq, then Equilibrium using particle with highest energy. Note it gets IST=kIStIntermediateState.
//genie::utils::intranuke2025::Equilibrium(ev,t,RemnA,RemnZ,RemnP4,DoFermi,FermiFac,Nuclmodel,NucRmvE,mode);

Expand Down
3 changes: 2 additions & 1 deletion src/Physics/HadronTransport/Intranuke.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,8 @@ void Intranuke::TransportHadrons(GHepRecord * evrec) const
GHepParticle * sp = new GHepParticle(*p);

// Set clone's mom to be the hadron that was cloned
sp->SetFirstMother(icurr);
sp->SetFirstMother(icurr);
sp->SetLastMother(-1); // in case mother had 2 mothers

// Check whether the particle can be rescattered
if(!this->CanRescatter(sp)) {
Expand Down
2 changes: 2 additions & 0 deletions src/Physics/HadronTransport/Intranuke2018.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ void Intranuke2018::TransportHadrons(GHepRecord * evrec) const

// Set clone's mom to be the hadron that was cloned
sp->SetFirstMother(icurr);
sp->SetLastMother(-1); // in case mother had 2 mothers

// Check whether the particle can be rescattered
if(!this->CanRescatter(sp)) {
Expand All @@ -328,6 +329,7 @@ void Intranuke2018::TransportHadrons(GHepRecord * evrec) const
LOG("Intranuke2018", pNOTICE)
<< "... Current version can't rescatter a " << sp->Name();
sp->SetFirstMother(icurr);
sp->SetLastMother(-1); // in case mother had 2 mothers
sp->SetStatus(kIStStableFinalState);
evrec->AddParticle(*sp);
delete sp;
Expand Down
2 changes: 2 additions & 0 deletions src/Physics/HadronTransport/Intranuke2025.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ void Intranuke2025::TransportHadrons(GHepRecord * evrec) const

// Set clone's mom to be the hadron that was cloned
sp->SetFirstMother(icurr);
sp->SetLastMother(-1); // in case mother had 2 mothers

// Check whether the particle can be rescattered
if(!this->CanRescatter(sp)) {
Expand All @@ -292,6 +293,7 @@ void Intranuke2025::TransportHadrons(GHepRecord * evrec) const
LOG("Intranuke2025", pNOTICE)
<< "... Current version can't rescatter a " << sp->Name();
sp->SetFirstMother(icurr);
sp->SetLastMother(-1); // in case mother had 2 mothers
sp->SetStatus(kIStStableFinalState);
evrec->AddParticle(*sp);
delete sp;
Expand Down