Updates for install-dir-in-experiment#1104
Draft
mathomp4 wants to merge 4 commits into
Draft
Conversation
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a suite of PRs to try and change how we handle
GEOSgcm.xin GEOS. The issue is that more and more of GEOS subcomponents are becoming shared object libraries instead of static.Overall Problem
That means the old trick of "copy someone else's
GEOSgcm.xto my experiment" might not work. Why? Well, in GEOSgcm v11.10+, the Moist GridComp (for example) is now a shared object library and so just copyingGEOSgcm.xisn't enough to actually use that other person's Moist GC code.What we change here
In this repo we call a new cmake script that runs after
install. It creates a "manifest" as it were. So, if a user has two experiments, you can compare the manifests that will be in the install to see what might have changed (not perfect, but better than nothing). For example, if you diff two manifests: