Skip to content

Add ISSM HISTORY, Restarts, and BCs#161

Open
agstub wants to merge 42 commits into
developfrom
feature/agstub/issm-history
Open

Add ISSM HISTORY, Restarts, and BCs#161
agstub wants to merge 42 commits into
developfrom
feature/agstub/issm-history

Conversation

@agstub

@agstub agstub commented Feb 11, 2026

Copy link
Copy Markdown

The purpose of this Draft PR is to (1) add new variables from ISSM (Ice-Sheet and Sea-Level System Model) to HISTORY, and deal with BCs files (prefixed ISSM*.*) and restarts (issm_internal_rst).

  • GEOSldas_HIST.rc: Added a new collection tavg24_1d_issm_Nt (Tile-space,Daily,Time-Averaged,Single-level,ISSM Diagnostics) for mesh tile space with variables (ICESURF, ICETHICK, ICEVX, ICEVY).
  • GEOSldas_HIST.rc: Added three ISSM outputs (ICESURF, ICETHICK, ICEVEL) and one ISSM input (ICESMB) to landice gridded collection (tavg24_2d_glac_Nx).
  • In lenkf_j_template.py: move ISSM_MESH.nc to rc_out, copy ISSM* files from input to scratch directory, and move issm_internal_checkpoint files to restart directory.
  • In ldas.py: link ISSM BCs and restarts, add ISSM restart/checkpoint filenames (issm_internal_rst/issm_internal_checkpoint) to configuration.
  • Update CHANGELOG.md

Current restrictions:
Running ISSM is not supported with zoom-in and Restart type 2. For the latter, we currently have no way of mapping between restarts for different ISSM BCs. Specifying these options results in an error/exit in ldas.py

For restart type M, issm_internal_rst will be bootstrapped from what is stored in the input files (i.e. ice surface, thickness, etc. associated with the BCs). This is a convenient way to generate an ISSM restart.

Related issues and PRs

@weiyuan-jiang

Copy link
Copy Markdown
Contributor

The variables in the same collection should have the same tile or gridded space. We have discussion that ISSM should have output in mesh-like space. So ICEEL should not be in this collection

@agstub

agstub commented Feb 12, 2026

Copy link
Copy Markdown
Author

The variables in the same collection should have the same tile or gridded space. We have discussion that ISSM should have output in mesh-like space. So ICEEL should not be in this collection

That makes sense! Should I make new collections for ISSM outputs (mesh tile collection and gridded collection)? Will we still want to save a gridded version of ice elevation @lcandre2 ?

@lcandre2

Copy link
Copy Markdown
Contributor

The variables in the same collection should have the same tile or gridded space. We have discussion that ISSM should have output in mesh-like space. So ICEEL should not be in this collection

That makes sense! Should I make new collections for ISSM outputs (mesh tile collection and gridded collection)? Will we still want to save a gridded version of ice elevation @lcandre2 ?

I would say that for standard ISSM outputs (elevation, ice velocity, ice discharge, perhaps a few others) it would be good to have both a tile and gridded collection.

@gmao-rreichle gmao-rreichle added 0-diff enhancement New feature or request labels Mar 23, 2026
@agstub agstub changed the title Add ISSM fields to HISTORY and initialization arguments Add ISSM HISTORY, Restarts, and BCs Apr 29, 2026
agstub and others added 2 commits April 29, 2026 16:19
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

lcandre2
lcandre2 previously approved these changes Jul 6, 2026
@biljanaorescanin

Copy link
Copy Markdown
Collaborator

This PR was tested, it is zero diff for all tests.

More details on summary here: GEOS-ESM/GEOSgcm_GridComp#1203 (comment)

@biljanaorescanin biljanaorescanin marked this pull request as ready for review July 8, 2026 21:55
@biljanaorescanin biljanaorescanin requested a review from a team as a code owner July 8, 2026 21:55
@biljanaorescanin

Copy link
Copy Markdown
Collaborator

@lcandre2 and @gmao-rreichle we will wait on your approval for this merge. Since it anyways needs GEOSgcm_GridComp to go in first. I will leave Do Not Approve label until then.

lcandre2
lcandre2 previously approved these changes Jul 9, 2026

@lcandre2 lcandre2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

5 participants