Skip to content

HOTFIX, updated LADAS default setup setting and resource files#177

Closed
gmao-qliu wants to merge 4 commits into
release/v3.1.0from
feature/qliu/ladas_new_nml_etc
Closed

HOTFIX, updated LADAS default setup setting and resource files#177
gmao-qliu wants to merge 4 commits into
release/v3.1.0from
feature/qliu/ladas_new_nml_etc

Conversation

@gmao-qliu

@gmao-qliu gmao-qliu commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

CLOSED 24 Jun 2026: Replaced by #178


This pull request introduces the following updates and fixes:

Replaced the old scaling parameters (which were based on the corrected "M21CLFO" precipitation) with new parameters derived from offline LDAS simulations using "M21CINT" precipitation forcing.

Updated the new default configuration to ensure the mwRTM "clay" parameter is consistent with NLv3.

Resolved the ref_time issue for HISTORY.rc.

Modified the default "ntasks" from 120 to 136 to ensure more than 1 node will be used.

In job script, remove "lmc", "obsparam", and "nml" files generated by GEOSldas.x when coupled to ADAS to avoid crash after rewind.

@gmao-qliu gmao-qliu requested a review from gmao-rreichle June 23, 2026 16:18
@gmao-qliu gmao-qliu requested a review from a team as a code owner June 23, 2026 16:18
@gmao-qliu gmao-qliu added 0-diff trivial very, very obvious 0-diff change hotfix labels Jun 23, 2026

@weiyuan-jiang weiyuan-jiang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.md

@gmao-qliu gmao-qliu changed the base branch from develop to release/v3.1.0 June 23, 2026 19:21
@gmao-rreichle

Copy link
Copy Markdown
Collaborator

@gmao-qliu : Thanks for putting this together. I added a couple of commits that improve comments/documentation.
Also, the name of the target branch should probably be "release/v3.1.1". Otherwise, after the merge, the branch labeled "v3.1.0" would contain what we want to be v3.1.1, which is very confusing. But let me check with the SI team first about how exactly I should create a hot fix release, and what the naming conventions are for the branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-diff trivial very, very obvious 0-diff change hotfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants