Skip to content

Replace 'use MAPL' with 'use MAPL2' in GEOS_Shared for MAPL→MAPL2→MAPL3 rename#414

Merged
mathomp4 merged 4 commits into
release/MAPL-v3from
feature/#4600-rename-MAPL-MAPL2-MAPL3-MAPL
Apr 2, 2026
Merged

Replace 'use MAPL' with 'use MAPL2' in GEOS_Shared for MAPL→MAPL2→MAPL3 rename#414
mathomp4 merged 4 commits into
release/MAPL-v3from
feature/#4600-rename-MAPL-MAPL2-MAPL3-MAPL

Conversation

@tclune
Copy link
Copy Markdown
Collaborator

@tclune tclune commented Apr 2, 2026

Summary

  • Replaces all bare use MAPL with use MAPL2 in 8 Fortran source files in GEOS_Shared/
  • Adds MAPL2 to CMake DEPENDENCIES in GEOS_Shared/CMakeLists.txt

These changes support the transitional MAPL→MAPL2→MAPL3 rename being coordinated across GEOS-ESM repos.

References

@tclune tclune requested review from a team as code owners April 2, 2026 14:47
Copy link
Copy Markdown
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tclune : Do we still have both libraries (MAPL and MAPL2) somehow in the system (per Line 11 of the CMakeLists.txt file)?

@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Apr 2, 2026

Sigh. The build issue is on me. I forgot to merge a previous @tclune PR (#412 )

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Skip Changelog Skips the Changelog Enforcer (use only when appropriate!) labels Apr 2, 2026
@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Apr 2, 2026

Wait. the CI is weirdly wrong. One moment.

@tclune
Copy link
Copy Markdown
Collaborator Author

tclune commented Apr 2, 2026

@tclune : Do we still have both libraries (MAPL and MAPL2) somehow in the system (per Line 11 of the CMakeLists.txt file)?

@gmao-rreichle Yes. We are whittling away the MAPL2 stuff that can be deleted and migrating the stuff that can't. So this step really is just a name change to make the name "MAPL" default to the MAPL v3.0 stuff that will survive. All the use MAPL2 stuff will need attention before we can release v3.0. (But the real work is all the layers of the GCM that are simply commented out on the MAPL3 branch.)

@mathomp4 mathomp4 merged commit c443cec into release/MAPL-v3 Apr 2, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. Skip Changelog Skips the Changelog Enforcer (use only when appropriate!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants