Port OVP.F90 off MAPL_GenericMod to MAPL3#419
Merged
Conversation
- Replace use MAPL2 with use MAPL and use mapl3g_GridGet - Replace MAPL_MetaComp/MAPL_GetObjectFromGC/MAPL_Get with MAPL_GridCompGet + GridGetCoordinates - Change LONS from REAL(R4) to REAL(R8) pointer (ESMF grid coords are R8) - Add MAPL.geom to CMake dependencies Closes #418
tclune
added
the
0 diff
Member
|
Grah. Let me fix the CI for spack. Dang it. |
mathomp4
added
the
Skip Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use MAPL2withuse MAPL+use mapl3g_GridGetMAPL_MetaComp/MAPL_GetObjectFromGC/MAPL_Get(STATE, LONS=...)withMAPL_GridCompGet(GC, grid=grid)+GridGetCoordinates(grid, LONS, lats)LONSfromREAL(ESMF_KIND_R4)toREAL(ESMF_KIND_R8)pointer (ESMF grid coords are R8)OVP_maskdummyLONSfromREALtoREAL(ESMF_KIND_R8)MAPL.geomto CMake dependenciesNote: callers of
OVP_initin GEOSgcm_GridComp (TR, GMI, ChemEnv) are currently commented out in CMake and will need updating when they are ported.Part of MAPL #4730.