Migrate use MAPL2 to use MAPL (MAPL3) in GEOS_Shared (#420)#421
Merged
Conversation
tclune
added
the
0 diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #420.
Migrates
use MAPL2touse MAPL(MAPL3) in 7 files inGEOS_Shared/. Where symbols are not yet available in MAPL3, explicituse MAPL2, only:statements are used to document what still needs to migrate.Changes per file
use MAPL, only:with explicit symbol listuse MAPL, only:(was already explicit)use MAPL, only:with explicit symbol listuse MAPL, only: MAPL_UNDEFuse MAPL, only: MAPL_PIuse MAPL+use MAPL2, only: MAPL_GridGet(MAPL3 GridGet interface conflict with globalCellCountPerDim)use MAPL+use MAPL2, only: MAPL_VarRead, GETFILE;cfargument changed fromESMF_ConfigtoESMF_HConfig;MAPL_MetaComp/MAPL_Set/MAPL_GetResourcereplaced with private helper subroutines using pure ESMF HConfig APINotes
MAPL_VarReadandGETFILEremain onuse MAPL2pending migration of those utilities to MAPL3MAPL_GridGetwithglobalCellCountPerDim=is not yet in MAPL3