Migrate GEOS_TopoGet from BinIO to NetCDF4#424
Merged
Conversation
- Replace GETFILE/MAPL_VarRead(unit)/FREE_FILE with Netcdf4_Fileformatter - Read topo fields using MAPL_VarRead with variable names: z, gwd, trb - Add _ASSERT for unsupported GWDVARX/Y/XY/YX arguments - Remove unsupported binary file branches and associated dead variables - MAPL_VarRead still sourced from MAPL2 pending NCIOMod migration to mapl_base3g
tclune
added
the
0 diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GETFILE/MAPL_VarRead(unit,...)/FREE_FILE(BinIO) withNetcdf4_FileformatterandMAPL_VarRead(formatter,name,ptr)from NCIOModz(MEAN),gwd(GWDVAR),trb(TRBVAR)_ASSERT(.not. present(...))guards forGWDVARX,GWDVARY,GWDVARXY,GWDVARYXwhich have no NetCDF equivalent yetunit,GWDFACX/Y/XY/YX) and unsupported file-fetch branchesMAPL_VarReadis temporarily sourced fromMAPL2pending migration ofNCIOModintomapl_base3g(tracked separately in MAPL)Notes
Binary/ASCII topo
.datafiles are no longer supported. NetCDF4 topo files must be provided.