Delete legacy MAPL_PackTime, MAPL_UnpackTime, MAPL_UnpackDateTime from Base_Base#4813
Closed
tclune wants to merge 8 commits into
Closed
Delete legacy MAPL_PackTime, MAPL_UnpackTime, MAPL_UnpackDateTime from Base_Base#4813tclune wants to merge 8 commits into
tclune wants to merge 8 commits into
Conversation
Provides MAPL_-prefixed named constructors for legacy integer-packed date/time representations (YYYYMMDD / HHMMSS), with overloads accepting either individual integer components or an ESMF_Time: MAPL_PackedDateCreate, MAPL_PackedTimeCreate, MAPL_PackedDateTimeCreate, MAPL_ESMFTimeFromPacked All four symbols are re-exported via mapl_base3g (API.F90) with the MAPL_ namespace prefix via use-rename. pFUnit tests cover all overloads and a round-trip through ESMFTimeFromPacked.
…4811) Pure-integer subroutines for unpacking YYYYMMDD, HHMMSS, and integer(2) packed datetimes into components. Re-exported via mapl_base3g (API.F90) with the MAPL_ prefix.
Covers basic unpacking, edge cases (midnight, epoch date), and a pack→unpack round-trip to verify the operations are proper inverses.
…Base These legacy integer-packed-time subroutines are now provided by MAPL_PackedTimeMod (base3g/PackedTime.F90). All compiled downstream consumers have been migrated. Closes #4811.
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged. |
…d ambiguity with Base_Base
…Base These legacy integer-packed-time subroutines are now provided by MAPL_PackedTimeMod (base3g/PackedTime.F90). All compiled downstream consumers have been migrated (GOCART#419, GMAO_Shared#426, GEOSgcm_App#866). Re-exports MAPL_UnpackTime/MAPL_UnpackDateTime via API.F90 now that the ambiguity with Base_Base is resolved. Closes #4811
tclune
force-pushed
the
feature/4811-delete-legacy-packed-time
branch
from
091ea45 to
ab4d98a
Compare
tclune
added
0 Diff
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge order
This PR must merge last, after all downstream consumers have migrated:
Closes #4811