Remove MAPL_PackDateTime and MAPL_IncYMD from Base_Base (#4815)#4816
Merged
Conversation
tclune
added
0 Diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
MAPL_PackDateTimeandMAPL_IncYMDfrombase/Base/Base_Base.F90andbase/Base/Base_Base_implementation.F90as part of the MAPL3 migration.Closes #4815
Changes
public MAPL_PackDateTime, itsmodule subroutineinterface declaration, and its implementation (6 lines)public MAPL_IncYMD, itsmodule functioninterface declaration, and its implementation (29 lines)Rationale
Both symbols have zero external callers anywhere in the GEOSgcm ecosystem:
MAPL_PackDateTime: no compiled callers foundMAPL_IncYMD: the wider ecosystem carries ~12 independent private copies of the legacy GLA GCMINCYMDalgorithm; noneUSE MAPL_Basefor thisRelated
MAPL_PackTime,MAPL_UnpackTime,MAPL_UnpackDateTime)