Remove zero-caller symbols from Base_Base: MAPL_GenXYOffset, MAPL_SetPointer, MAPL_RemapBounds, MAPL_PinFlagSet/Get (#4817)#4818
Merged
Conversation
Remove MAPL_GenXYOffset, MAPL_SetPointer (x2), MAPL_RemapBounds (x3), MAPL_PinFlagSet, MAPL_PinFlagGet — all confirmed zero external callers. Also remove the pinflag_global module variable and inline the default value (ESMF_PIN_DE_TO_SSI_CONTIG) directly in MAPL_FieldAllocCommit, which was the only remaining internal caller of MAPL_PinFlagGet. If/when SSI pinning is needed in MAPL3 it should be properly integrated into v3 FieldCreate/FieldEmptyComplete rather than via a module variable. Part of MAPL3 Base migration (#4805).
mathomp4
added
the
0 Diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove five public symbols (nine procedures total) from
base/Base/Base_Base.F90andbase/Base/Base_Base_implementation.F90— all confirmed to have zero external callers anywhere in the GEOSgcm ecosystem.Closes #4817
Symbols removed
MAPL_GenXYOffset— detects PC/PE and DC/DE grid offset from lon/lat arraysMAPL_SetPointer(x2:MAPL_SetPointer2DR4,MAPL_SetPointer3DR4) — points R4 array pointer at named field in ESMF stateMAPL_RemapBounds(x3:MAPL_RemapBoundsFull_3dr4,MAPL_RemapBounds_3dr4,MAPL_RemapBounds_3dr8) — remaps lower bounds of 3D array pointerMAPL_PinFlagSet/MAPL_PinFlagGet— get/set a module-levelESMF_PIN_FLAGvariable; also removes thepinflag_globalmodule variableAlso inlines the default pin flag value (
ESMF_PIN_DE_TO_SSI_CONTIG) directly intoMAPL_FieldAllocCommit, which was the only remaining internal caller ofMAPL_PinFlagGet. If/when SSI pinning is needed in MAPL3 it should be properly integrated into v3FieldCreate/FieldEmptyCompleterather than via a module variable.Related