Use ObsBuilder scripts from SPOC in bufr conversion#830
Draft
mranst wants to merge 8 commits into
Draft
Conversation
Contributor
|
A few questions/notes: 1. "It seems like the scripts are expecting the corresponding yamls to live in the same directory they are being executed from? I may be misunderstanding something, but i added this process to CloneSpoc to accomodate:"
run/20231010T000000Z/geos_atmosphere/ 2. "The output ioda files seem to be combined with all satId's in one file, not sure how significant this is"
|
cohen-seth
reviewed
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Are these obs builder python scripts placeholders?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#773
I've been experimenting a bit with using the spoc scripts in the bufr-to-ioda conversion to see if I could get it work. I believe it mostly works, but it is a somewhat crude implementation, so it will probably require some fine-tuning from people more familiar with obs handling
This PR adds the
CloneSpoctask, which can grab a branch set byspoc_taginexperiment.yaml, or point to an existingspoc_source_directory.Bufr2Iodathen uses the scripts to run the conversion.A few questions/notes:
It seems like the scripts are expecting the corresponding yamls to live in the same directory they are being executed from? I may be misunderstanding something, but i added this process to CloneSpoc to accomodate:
swell/src/swell/tasks/clone_spoc.py
Lines 66 to 71 in eca7d5c
The output ioda files seem to be combined with all satId's in one file, not sure how significant this is
There are some obs types that have separate yamls under the bufr2netcdf.x schema, that don't have individual python scripts (I think this is noted in Incorporating SPOC into swell convert_bufr suite #773)