feat: enhance product/banner image validation (#14)#735
Draft
XtarXyan wants to merge 1 commit into
Draft
Conversation
JustSamuel
force-pushed
the
feature/EnhanceImageValidation
branch
from
93a7056 to
b88cd68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses Issue #14 by adding a new validation function
validateImageUploadwhich checks an uploaded image for an appropriate format, resolution and aspect ratio in conformity with the purpose of the image. Files product-controller and banner-controller utilize this function to validate image upload requests and return an HTTP error 400 if the images are invalid.Related issues/external references
#14 Enhance product/banner image validation
Types of changes
✅ PR Checklist
npm run test)🔗 Additional Notes