feat: increase precision and range of vehicle attributes encoded values (#111)

The change is necessary in order to match the original ORS behavior after the transition from extended storage to encoded values introduced by GIScience/openrouteservice#2146.

Author: aoles

core/src/main/java/com/graphhopper/routing/ev/MaxAxleLoad.java

@@ -29,6 +29,9 @@ public class MaxAxleLoad {
      * it was done with the MappedDecimalEncodedValue still handling (or rounding) of unknown values is unclear.
      */
     public static DecimalEncodedValue create() {
-        return new UnsignedDecimalEncodedValue(KEY, 7, 0.5, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD START: increased precision and range to match former ORS behavior
+        // 9 bits with factor 0.1 allows to store values from 0.1 to 51.1 tons
+        return new UnsignedDecimalEncodedValue(KEY, 9, 0.1, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD END
     }
 }

core/src/main/java/com/graphhopper/routing/ev/MaxHeight.java

@@ -32,6 +32,9 @@ public class MaxHeight {
      * it is assumed to use the maximum value.
      */
     public static DecimalEncodedValue create() {
-        return new UnsignedDecimalEncodedValue(KEY, 7, 0.1, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD START: increased precision and range to match former ORS behavior
+        // 11 bits with factor 0.01 allows to store values from 0.01 to 20.47 meters
+        return new UnsignedDecimalEncodedValue(KEY, 11, 0.01, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD END
     }
 }

core/src/main/java/com/graphhopper/routing/ev/MaxLength.java

@@ -32,6 +32,9 @@ public class MaxLength {
      * between the maximum and infinity it is assumed to use the maximum value.
      */
     public static DecimalEncodedValue create() {
-        return new UnsignedDecimalEncodedValue(KEY, 7, 0.1, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD START: increased precision and range to match former ORS behavior
+        // 9 bits with factor 0.1 allows to store values from 0.1 to 51.1 meters
+        return new UnsignedDecimalEncodedValue(KEY, 9, 0.1, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD END
     }
 }

core/src/main/java/com/graphhopper/routing/ev/MaxWeight.java

@@ -33,6 +33,9 @@ public class MaxWeight {
      * it was done with the MappedDecimalEncodedValue still handling (or rounding) of unknown values is unclear.
      */
     public static DecimalEncodedValue create() {
-        return new UnsignedDecimalEncodedValue(KEY, 8, 0.1, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD START: increased precision and range to match former ORS behavior
+        // 11 bits with factor 0.1 allows to store values from 0.1 to 204.7 tons
+        return new UnsignedDecimalEncodedValue(KEY, 11, 0.1, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD END
     }
 }

core/src/main/java/com/graphhopper/routing/ev/MaxWidth.java

@@ -32,6 +32,9 @@ public class MaxWidth {
      * it is assumed to use the maximum value.
      */
     public static DecimalEncodedValue create() {
-        return new UnsignedDecimalEncodedValue(KEY, 7, 0.1, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD START: increased precision to match former ORS behavior
+        // 10 bits with factor 0.01 allows to store values from 0.01 to 10.23 meters
+        return new UnsignedDecimalEncodedValue(KEY, 10, 0.01, Double.POSITIVE_INFINITY, false);
+        // ORS-GH MOD END
     }
 }

core/src/test/java/com/graphhopper/routing/util/parsers/OSMMaxAxleLoadParserTest.java

@@ -6,6 +6,7 @@
 import com.graphhopper.routing.util.EncodingManager;
 import com.graphhopper.storage.IntsRef;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -41,6 +42,7 @@ public void testSimpleTags() {
     }
 
     @Test
+    @Disabled("Behavior changed due to ORS-specific modifications, see MaxAxleLoad")
     public void testRounding() {
         ReaderWay readerWay = new ReaderWay(1);
         IntsRef intsRef = em.createEdgeFlags();

core/src/test/java/com/graphhopper/routing/util/parsers/OSMMaxWeightParserTest.java

@@ -6,6 +6,7 @@
 import com.graphhopper.routing.util.EncodingManager;
 import com.graphhopper.storage.IntsRef;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -24,6 +25,7 @@ public void setUp() {
     }
 
     @Test
+    @Disabled("Behavior changed due to ORS-specific modifications, see MaxWeight")
     public void testSimpleTags() {
         ReaderWay readerWay = new ReaderWay(1);
         IntsRef intsRef = em.createEdgeFlags();