fix: bug in MinorNodes missing visibily check

Author: rtroilo

ohsome-contributions/src/main/java/org/heigit/ohsome/contributions/minor/MinorNode.java

@@ -88,10 +88,10 @@ public static void serialize(Output output, List<OSMNode> versions) {
                 var userName = version.user();
                 output.writeU32(userId);
                 output.writeUTF8(userName);
-                var l = Math.round((version.lon() * 1_0000000L));
+                var l = version.visible() ? Math.round((version.lon() * 1_0000000L)) : lon;
                 output.writeS64(l - lon);
                 lon = l;
-                l = Math.round(version.lat() * 1_0000000L);
+                l = version.visible() ? Math.round(version.lat() * 1_0000000L) : lat;
                 output.writeS64(l - lat);
                 lat = l;
             }

ohsome-contributions/src/test/java/org/heigit/ohsome/contributions/minor/MinorTest.java

@@ -14,6 +14,29 @@
 
 class MinorTest {
 
+
+    @Test
+    void testNode() throws IOException {
+        var builder = MinorNode.newBuilder();
+        builder.add(new OSMEntity.OSMNode(123, 0, ofEpochSecond(0), 0, 1, "test", true, Map.of(), 8.7244722, 52.3270159));
+        builder.add(new OSMEntity.OSMNode(123, 1, ofEpochSecond(1), 1, 1, "test", false, Map.of(), 214.7483647, 214.7483647));
+
+        try (var output = new Output(4 << 10)) {
+            builder.serialize(output);
+            var bytes = output.array();
+            var osh = MinorNode.deserialize(123L, bytes);
+            var node1 = osh.get(0);
+            System.out.println("node1 = " + node1);
+
+            var node2 = osh.get(1);
+            System.out.println("node2 = " + node2);
+
+            assertFalse(node2.visible());
+
+        }
+
+    }
+
     @Test
     void testMinorNode() throws IOException {
         var builder = MinorNode.newBuilder();