Skip to content

refactor: migrate borders storage to encoded values#2281

Draft
aoles wants to merge 13 commits into
mainfrom
refactor/migrate_borders_storage_to_enc_values
Draft

refactor: migrate borders storage to encoded values#2281
aoles wants to merge 13 commits into
mainfrom
refactor/migrate_borders_storage_to_enc_values

Conversation

@aoles
Copy link
Copy Markdown
Member

@aoles aoles commented May 8, 2026

👉 To be run against GIScience/graphhopper#115 👈

TODO

  • proper solution for CountryBordersReader including serialization
  • account for unprocessed pbf (= process country geometries in ORS)
  • re-introduce unit tests, now for BorderParser
  • add custom country codes for corresponding to ORS country ids to GH's Country encoded value (within feat: expose node ids to tag parsers graphhopper#115)

@github-actions github-actions Bot added refactor and removed refactor labels May 8, 2026
@aoles aoles force-pushed the refactor/migrate_borders_storage_to_enc_values branch from 2327720 to 9e7ea22 Compare May 8, 2026 14:54
aoles and others added 3 commits May 12, 2026 10:58
Co-authored-by: Sascha Fendrich <sascha.fendrich@heigit.org>
Co-authored-by: Sascha Fendrich <sascha.fendrich@heigit.org>
@aoles aoles force-pushed the refactor/migrate_borders_storage_to_enc_values branch 2 times, most recently from 4dd6fbc to af84520 Compare May 13, 2026 10:29
sfendrich
sfendrich previously approved these changes May 18, 2026
Copy link
Copy Markdown
Contributor

@sfendrich sfendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfendrich sfendrich dismissed their stale review May 18, 2026 08:49

approved by accident.

aoles and others added 4 commits May 19, 2026 22:09
Co-authored-by: Sascha Fendrich <sascha.fendrich@heigit.org>
Co-authored-by: Sascha Fendrich <sascha.fendrich@heigit.org>
Co-authored-by: Sascha Fendrich <sascha.fendrich@heigit.org>
aoles and others added 4 commits May 19, 2026 22:10
Co-authored-by: Sascha Fendrich <sascha.fendrich@heigit.org>
Co-authored-by: Sascha Fendrich <sascha.fendrich@heigit.org>
@aoles aoles force-pushed the refactor/migrate_borders_storage_to_enc_values branch 2 times, most recently from 76b6b79 to 92c133c Compare May 21, 2026 06:59
@aoles aoles force-pushed the refactor/migrate_borders_storage_to_enc_values branch from 92c133c to 472f8d2 Compare May 21, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants