refactor: migrate wheelchair attributes storage to encoded values (WIP)#2284
Draft
jarinox wants to merge 11 commits into
Draft
refactor: migrate wheelchair attributes storage to encoded values (WIP)#2284jarinox wants to merge 11 commits into
jarinox wants to merge 11 commits into
Conversation
WheelchairAttributes are stored in EncodedValues instead of GraphStorage: - implement parsers for all attributes - read WheelchairValues from EncodedValues
8a9fa8a to
623bca3
Compare
17b73c5 to
2f6e9a7
Compare
2f6e9a7 to
6319f06
Compare
ec8ad6a to
8e04925
Compare
|
Contributor
Author
|
@aoles As you proposed, I created some basic new parsers based on the original Through that process, I eliminated the remaining issues with the new parsers. They are now all enabled and produce the exact same results as the old ones. I've also started cleaning up the deprecated code. One remaining question: What is the best way to expose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes #993
Information about the changes