Skip to content

refactor: migrate wheelchair attributes storage to encoded values (WIP) #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jarinox wants to merge 11 commits into
base: main
Choose a base branch
from

chore: clean up (remove deprecated WheelchairGraphStorageBuilder)

8e04925
Select commit
Loading
Failed to load commit list.
Draft

refactor: migrate wheelchair attributes storage to encoded values (WIP) #2284

chore: clean up (remove deprecated WheelchairGraphStorageBuilder)
8e04925
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 2, 2026 in 1m 20s

Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 103 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/util/parsers/wheelchair/WheelchairKerbHeightParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this block of code, fill it in, or add a comment explaining why it is empty. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iYLiwcqmXarFp6d&open=AZ5j0iYLiwcqmXarFp6d&pullRequest=2284

Check failure on line 195 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/util/parsers/wheelchair/WheelchairBaseParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iYkiwcqmXarFp6u&open=AZ5j0iYkiwcqmXarFp6u&pullRequest=2284

Check warning on line 22 in ors-engine/src/main/java/org/heigit/ors/export/ExportRequest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.heigit.ors.routing.graphhopper.extensions.storages.GraphStorageUtils'. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iZriwcqmXarFp63&open=AZ5j0iZriwcqmXarFp63&pullRequest=2284

Check warning on line 15 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/util/parsers/wheelchair/WheelchairKerbHeightParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iYLiwcqmXarFp6c&open=AZ5j0iYLiwcqmXarFp6c&pullRequest=2284

Check warning on line 254 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/ORSOSMReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 70 to 64, Complexity from 22 to 14, Nesting Level from 5 to 2, Number of Variables from 21 to 6. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iZOiwcqmXarFp62&open=AZ5j0iZOiwcqmXarFp62&pullRequest=2284

Check warning on line 3 in ors-engine/src/main/java/com/graphhopper/routing/ev/WheelchairTrackType.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0ia3iwcqmXarFp66&open=AZ5j0ia3iwcqmXarFp66&pullRequest=2284

Check warning on line 3 in ors-engine/src/main/java/com/graphhopper/routing/ev/WheelchairSmoothness.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0ibFiwcqmXarFp68&open=AZ5j0ibFiwcqmXarFp68&pullRequest=2284

Check warning on line 30 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/edgefilters/WheelchairEdgeFilter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from constructor's body. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ6H2FfxXTOyTD3r6wSy&open=AZ6H2FfxXTOyTD3r6wSy&pullRequest=2284

Check warning on line 6 in ors-engine/src/main/java/com/graphhopper/routing/ev/WheelchairSide.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0ibNiwcqmXarFp69&open=AZ5j0ibNiwcqmXarFp69&pullRequest=2284

Check warning on line 18 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/util/WheelchairAttributesEncodedValues.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make osmWayIdEnc a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iY5iwcqmXarFp61&open=AZ5j0iY5iwcqmXarFp61&pullRequest=2284

Check warning on line 265 in ors-engine/src/test/java/org/heigit/ors/routing/graphhopper/extensions/util/parsers/WheelchairParserTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0ibViwcqmXarFp6_&open=AZ5j0ibViwcqmXarFp6_&pullRequest=2284

Check warning on line 15 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/util/parsers/wheelchair/WheelchairKerbHeightParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static kerbHeightOnlyOnCrossing" field final 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iYLiwcqmXarFp6b&open=AZ5j0iYLiwcqmXarFp6b&pullRequest=2284

Check warning on line 15 in ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/util/parsers/wheelchair/WheelchairKerbHeightParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make kerbHeightOnlyOnCrossing a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0iYLiwcqmXarFp6a&open=AZ5j0iYLiwcqmXarFp6a&pullRequest=2284

Check warning on line 3 in ors-engine/src/main/java/com/graphhopper/routing/ev/WheelchairSurface.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0ia-iwcqmXarFp67&open=AZ5j0ia-iwcqmXarFp67&pullRequest=2284

Check failure on line 261 in ors-engine/src/test/java/org/heigit/ors/routing/graphhopper/extensions/util/parsers/WheelchairParserTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=GIScience_openrouteservice&issues=AZ5j0ibViwcqmXarFp6-&open=AZ5j0ibViwcqmXarFp6-&pullRequest=2284
View more details on SonarQubeCloud