experimental: graphhopper upgrade fixes#2289
Closed
MichaelsJP wants to merge 13 commits into
Closed
Conversation
…ions This fixes the test suite errors: Neither 'findJsonValueMethod' nor 'findJsonValueAccessor' found in jackson BeanDescription.
… graph EncodedValues such as sac_scale and mtb_scale were leaking into driving and wheelchair graphs and ransit/freight EVs (max_height, hgv_access, etc.) into walking graphs. BuildProperties.merge() uses an orElse strategy that inherits any 'true' flag set in profile_default. This adds a categorical filter in setGraphLevelEncodedValues() using RoutingProfileCategory and GraphHopper's own EncodedValue.KEY constants. Hiking/MTB EVs are now blocked for DRIVING and WHEELCHAIR. Transit EVs are blocked for WALKING and WHEELCHAIR; CYCLING passes all EVs through. A Javadoc TODO marks this filter block for removal if ORS ever adopts a unified graph architecture, where graph.encoded_values must be the full union of all profile EVs and leakage prevention moves to the individual FlagEncoder/VehicleTagParser layer.
…reLandmarkStorage
…erBarrierTest for barrier node handling
…, and CoreLMPreparationHandler
…or multi-encoder scenarios
MichaelsJP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)