Skip to content

Commit 98119e3

Browse files
authored
Update AWS deployment workflow for Weka API URLs
*_URL values should be defined as `variables` instead of `secrets` to simplify devops. This PR addresses only those values used by `nshm-weka-apigw` to prove this works as expected.
1 parent 709af33 commit 98119e3

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

.github/workflows/deploy-to-aws.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,19 @@ name: Deploy to AWS
1212
# - AWS_SECRET_ACCESS_KEY
1313

1414
# supported secrets for deployment step:
15-
# - NZSHM22_TOSHI_API_URL
1615
# - NZSHM22_TOSHI_API_KEY
17-
# - NZSHM22_NSHM_MODEL_API_URL
1816
# - NZSHM22_NSHM_MODEL_API_KEY
1917
# - NZSHM22_KORORAA_API_URL
2018
# - NZSHM22_KORORAA_API_KEY
2119
# - NZSHM22_SOLVIS_API_URL
2220
# - NZSHM22_SOLVIS_API_KEY
2321
# - SERVERLESS_ACCESS_KEY
22+
# - NZSHM22_HAZARD_API_KEY
2423

2524
# supported vars for deployment step:
26-
# - NZSHM22_HAZARD_API_KEY
25+
# - NZSHM22_NSHM_MODEL_API_URL
26+
# - NZSHM22_TOSHI_API_URL
27+
# - NZSHM22_HAZARD_API_URL
2728
# - ES_HOST (Elastic search specified as an environment variable)
2829

2930
on:
@@ -165,15 +166,15 @@ jobs:
165166
# secrets
166167
NZSHM22_KORORAA_API_URL: ${{ secrets.NZSHM22_KORORAA_API_URL }}
167168
NZSHM22_KORORAA_API_KEY: ${{ secrets.NZSHM22_KORORAA_API_KEY }}
168-
NZSHM22_TOSHI_API_URL: ${{ secrets.NZSHM22_TOSHI_API_URL }}
169169
NZSHM22_TOSHI_API_KEY: ${{ secrets.NZSHM22_TOSHI_API_KEY }}
170-
NZSHM22_NSHM_MODEL_API_URL: ${{ secrets.NZSHM22_NSHM_MODEL_API_URL }}
171170
NZSHM22_NSHM_MODEL_API_KEY: ${{ secrets.NZSHM22_NSHM_MODEL_API_KEY }}
172171
NZSHM22_SOLVIS_API_URL: ${{ secrets.NZSHM22_SOLVIS_API_URL }}
173172
NZSHM22_SOLVIS_API_KEY: ${{ secrets.NZSHM22_SOLVIS_API_KEY }}
174173
NZSHM22_HAZARD_API_KEY: ${{ secrets.NZSHM22_HAZARD_API_KEY }}
175174
SERVERLESS_ACCESS_KEY: ${{ secrets.SERVERLESS_ACCESS_KEY }}
176175
# vars
176+
NZSHM22_NSHM_MODEL_API_URL: ${{ vars.NZSHM22_NSHM_MODEL_API_URL }}
177+
NZSHM22_TOSHI_API_URL: ${{ vars.NZSHM22_TOSHI_API_URL }}
177178
NZSHM22_HAZARD_API_URL: ${{ vars.NZSHM22_HAZARD_API_URL }}
178179
ES_HOST: ${{ vars.ES_HOST }}
179180

@@ -186,15 +187,15 @@ jobs:
186187
# secrets
187188
NZSHM22_KORORAA_API_URL: ${{ secrets.NZSHM22_KORORAA_API_URL }}
188189
NZSHM22_KORORAA_API_KEY: ${{ secrets.NZSHM22_KORORAA_API_KEY }}
189-
NZSHM22_TOSHI_API_URL: ${{ secrets.NZSHM22_TOSHI_API_URL }}
190190
NZSHM22_TOSHI_API_KEY: ${{ secrets.NZSHM22_TOSHI_API_KEY }}
191-
NZSHM22_NSHM_MODEL_API_URL: ${{ secrets.NZSHM22_NSHM_MODEL_API_URL }}
192191
NZSHM22_NSHM_MODEL_API_KEY: ${{ secrets.NZSHM22_NSHM_MODEL_API_KEY }}
193192
NZSHM22_SOLVIS_API_URL: ${{ secrets.NZSHM22_SOLVIS_API_URL }}
194193
NZSHM22_SOLVIS_API_KEY: ${{ secrets.NZSHM22_SOLVIS_API_KEY }}
195194
NZSHM22_HAZARD_API_KEY: ${{ secrets.NZSHM22_HAZARD_API_KEY }}
196195
SERVERLESS_ACCESS_KEY: ${{ secrets.SERVERLESS_ACCESS_KEY }}
197196
# vars
197+
NZSHM22_NSHM_MODEL_API_URL: ${{ vars.NZSHM22_NSHM_MODEL_API_URL }}
198+
NZSHM22_TOSHI_API_URL: ${{ vars.NZSHM22_TOSHI_API_URL }}
198199
NZSHM22_HAZARD_API_URL: ${{ vars.NZSHM22_HAZARD_API_URL }}
199200
ES_HOST: ${{ vars.ES_HOST }}
200201

0 commit comments

Comments
 (0)