Skip to content

Chore/17 yarn2 and node lock file#18

Merged
chrisbc merged 10 commits into
deploy-testfrom
chore/17_yarn2_and_node_lock_file
Sep 22, 2025
Merged

Chore/17 yarn2 and node lock file#18
chrisbc merged 10 commits into
deploy-testfrom
chore/17_yarn2_and_node_lock_file

Conversation

@chrisbc

@chrisbc chrisbc commented Sep 22, 2025

Copy link
Copy Markdown
Member
  • most of CHORE: nshm-hazard-graphql-api is missing a lock file #17
  • this merge will find out if yarn 2 deployment works properly :)
  • this also updates some python libs that have security advisories
  • new ticket required to get sis wsgi serve working
  • codecov alert is trigger by the black update

@codecov

codecov Bot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.62%. Comparing base (9c6199c) to head (c7ced85).
⚠️ Report is 12 commits behind head on deploy-test.

Files with missing lines Patch % Lines
..._api/schema/toshi_hazard/gridded_hazard_helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           deploy-test      #18   +/-   ##
============================================
  Coverage        90.62%   90.62%           
============================================
  Files               14       14           
  Lines              480      480           
  Branches            33       33           
============================================
  Hits               435      435           
  Misses              38       38           
  Partials             7        7           
Flag Coverage Δ
unittests 90.62% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisbc chrisbc marked this pull request as ready for review September 22, 2025 22:19
@chrisbc chrisbc requested review from chrisdicaprio and voj and removed request for voj September 22, 2025 22:20

@voj voj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisbc chrisbc merged commit 33e9311 into deploy-test Sep 22, 2025
2 of 3 checks passed
@chrisbc chrisbc deleted the chore/17_yarn2_and_node_lock_file branch September 22, 2025 22:44
@chrisbc chrisbc mentioned this pull request Oct 20, 2025
chrisbc added a commit that referenced this pull request Oct 20, 2025
Merge deplo- test to main

- latest THS Chore/update to latest ths #8
- ECR deployment [14] update ECR base image and upstream libs #15
- yarn lock file Chore/17 yarn2 and node lock file #18
- serverless V4 migration Chore/20 serverless v4 migration #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants