Skip to content

Chore/advisories plus solvis 1.0#74

Merged
chrisbc merged 36 commits intodeploy-testfrom
chore/advisories_plus_solvis_1.0
Oct 6, 2025
Merged

Chore/advisories plus solvis 1.0#74
chrisbc merged 36 commits intodeploy-testfrom
chore/advisories_plus_solvis_1.0

Conversation

@chrisbc
Copy link
Copy Markdown
Member

@chrisbc chrisbc commented Sep 29, 2025

  • closes CHORE: solvis-graphql-api is missing a node lock file #72
  • closes CHORE: sanity check update to use new solvis 1.0.0 #60
  • migrates to ECR style deployment (see DEPLOYMENT.md)
  • added cli_ab_test script to help verify API stability end-to-end
  • geojson feature json now includes default values for styling: fill-opacity and fill-stroke.
    It's not clear how this is not already in deploy-test but it isn't. Do not expect any visual changes in Kororaa as the UI doesn't rely on the API default styling for its' presentation layer. BUT the rupture download geojson will see the new default attributes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 97.02128% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.80%. Comparing base (a7d4af6) to head (ef80b71).
⚠️ Report is 37 commits behind head on deploy-test.

Files with missing lines Patch % Lines
solvis_graphql_api/composite_solution/cached.py 88.88% 4 Missing ⚠️
...i/composite_solution/composite_rupture_sections.py 88.57% 4 Missing ⚠️
solvis_graphql_api/data_store/model.py 80.00% 3 Missing and 1 partial ⚠️
solvis_graphql_api/data_store/config.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           deploy-test      #74      +/-   ##
===============================================
+ Coverage        90.63%   95.80%   +5.16%     
===============================================
  Files               16       20       +4     
  Lines              790     1143     +353     
  Branches            61       54       -7     
===============================================
+ Hits               716     1095     +379     
+ Misses              67       34      -33     
- Partials             7       14       +7     
Flag Coverage Δ
unittests 95.80% <97.02%> (+5.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisbc chrisbc requested review from chrisdicaprio and voj October 2, 2025 01:08
@chrisbc chrisbc marked this pull request as ready for review October 2, 2025 01:08
Copy link
Copy Markdown
Collaborator

@voj voj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments.

Did you check the "check this" part of the PR description?

Comment thread DEPLOYMENT.md Outdated
Comment thread requirements.txt Outdated
Comment thread requirements.txt Outdated
Comment thread solvis_graphql_api/ab_test/client/dev_schema.py
Comment thread solvis_graphql_api/data_store/config.py Outdated
Comment thread solvis_graphql_api/scripts/cli_ab_test.py Outdated
Comment thread solvis_graphql_api/solution_schema.py
Copy link
Copy Markdown
Collaborator

@chrisdicaprio chrisdicaprio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few questions and suggestions

Comment thread DEPLOYMENT.md Outdated
Comment thread DEPLOYMENT.md Outdated
Comment thread DEPLOYMENT.md
Comment thread pyproject.toml Outdated
Comment thread solvis_graphql_api/composite_solution/composite_rupture_detail.py
@chrisbc chrisbc merged commit 0d646ce into deploy-test Oct 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants