Chore/advisories plus solvis 1.0#74
Merged
chrisbc merged 36 commits intodeploy-testfrom Oct 6, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## deploy-test #74 +/- ##
===============================================
+ Coverage 90.63% 95.80% +5.16%
===============================================
Files 16 20 +4
Lines 790 1143 +353
Branches 61 54 -7
===============================================
+ Hits 716 1095 +379
+ Misses 67 34 -33
- Partials 7 14 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 29, 2025
Closed
… release.yml; updated deployment workflow;
voj
approved these changes
Oct 5, 2025
Collaborator
voj
left a comment
There was a problem hiding this comment.
LGTM, minor comments.
Did you check the "check this" part of the PR description?
chrisdicaprio
approved these changes
Oct 5, 2025
Collaborator
chrisdicaprio
left a comment
There was a problem hiding this comment.
Looks good! Just a few questions and suggestions
…dd README in `ab_test` describing ab_test usage;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli_ab_testscript to help verify API stability end-to-endfill-opacityandfill-stroke.It's not clear how this is not already in deploy-test but it isn't. Do not expect any visual changes in Kororaa as the UI doesn't rely on the API default styling for its' presentation layer. BUT the rupture download geojson will see the new default attributes.