DTensor<T>::parseFromTextFile throws invalid_argument if T is unsupported

alphaville · alphaville · commit 02ed0a180016 · 2024-11-29T00:49:51.000Z
diff --git a/include/tensor.cuh b/include/tensor.cuh
@@ -629,8 +629,9 @@ data_t<T> vectorFromFile(std::string path_to_file) {
             vecDataFromFile[i] = std::stoull(line.c_str());
         } else if constexpr (std::is_same_v<T, size_t>) {
             sscanf(line.c_str(), "%zu", &vecDataFromFile[i]);
+        }  else {
+            throw std::invalid_argument("data type not supported");
         }
-        // todo
 
         if (++i == numElements) break;
     }

Original file line number	Diff line number	Diff line change
`@@ -629,8 +629,9 @@ data_t<T> vectorFromFile(std::string path_to_file) {`
`629`	`629`	`vecDataFromFile[i] = std::stoull(line.c_str());`
`630`	`630`	`} else if constexpr (std::is_same_v<T, size_t>) {`
`631`	`631`	`sscanf(line.c_str(), "%zu", &vecDataFromFile[i]);`
	`632`	`+ } else {`
	`633`	`+ throw std::invalid_argument("data type not supported");`
`632`	`634`	`}`
`633`		`- // todo`
`634`	`635`
`635`	`636`	`if (++i == numElements) break;`
`636`	`637`	`}`