Skip to content

Update tests to not use Br instruction #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotrAMD merged 1 commit into from
Apr 1, 2026
Merged

Update tests to not use Br instruction #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/unit/interface/OpMapTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,17 @@ TEST(OpMapBasicTestsName, CoreOpContainsTests) {
OpMap<StringRef> map;

OpDescription retDesc = OpDescription::fromCoreOp(Instruction::Ret);
OpDescription brDesc = OpDescription::fromCoreOp(Instruction::Br);

@mariusz-sikora-at-amd mariusz-sikora-at-amd Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safe to change this test, the main purpose of this test is not to test Br instruction. Ret and Br are (were) two first Core LLVM instructions.

OpDescription callBrDesc = OpDescription::fromCoreOp(Instruction::CallBr);
map[retDesc] = "RetInst";

EXPECT_TRUE(map.containsCoreOp(Instruction::Ret));
EXPECT_FALSE(map.containsCoreOp(Instruction::Br));
EXPECT_FALSE(map.containsCoreOp(Instruction::CallBr));
EXPECT_EQ(map[retDesc], "RetInst");

map[brDesc] = "BrInst";
map[callBrDesc] = "CallBrInst";
EXPECT_EQ(map[retDesc], "RetInst");
EXPECT_TRUE(map.containsCoreOp(Instruction::Br));
EXPECT_EQ(map[brDesc], "BrInst");
EXPECT_TRUE(map.containsCoreOp(Instruction::CallBr));
EXPECT_EQ(map[callBrDesc], "CallBrInst");
}

TEST(OpMapBasicTestsName, IntrinsicOpContainsTests) {
Expand Down
4 changes: 2 additions & 2 deletions test/unit/interface/OpSetTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ TEST(DialectsOpSetSizeTestsName, NonEmptyOpDescriptionsTemplatizedMakerTest) {
}

TEST(DialectsOpSetContainsTestsName, containsCoreOps) {
const OpSet set = OpSet::fromCoreOpcodes({1, 2}); // Ret, Br
const OpSet set = OpSet::fromCoreOpcodes({Instruction::Ret, Instruction::CallBr});
EXPECT_TRUE(set.containsCoreOp(Instruction::Ret));
EXPECT_TRUE(set.containsCoreOp(Instruction::Br));
EXPECT_TRUE(set.containsCoreOp(Instruction::CallBr));
EXPECT_FALSE(set.containsCoreOp(Instruction::Switch));
}

Expand Down
Loading