Fix FrameInterpolationSwapChainDX12::ResizeBuffers not handling a 0 buffer count properly#23
Open
LukeFZ wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:release-FSR3-3.0.3from
Open
Conversation
Calling ResizeBuffers with BufferCount = 0 means that we should preserve the original buffer count. Until now this did actually set the game buffer count to zero, causing crashes on subsequent GetBuffer calls.
lzlrd
added a commit
to lzlrd/dlssg-to-fsr3
that referenced
this pull request
May 22, 2024
This updates to FSR3 3.0.4 and includes the following patches: - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#12 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#23 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#56 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#57
lzlrd
added a commit
to lzlrd/dlssg-to-fsr3
that referenced
this pull request
May 22, 2024
This updates to FSR3 3.0.4 and includes the following patches: - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#12 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#23 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#56 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#57 ...as well as adding additional exports required here.
lzlrd
added a commit
to lzlrd/dlssg-to-fsr3
that referenced
this pull request
Jun 2, 2024
This updates to FSR3 3.0.4 and includes the following patches: - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#12 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#23 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#56 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#57 ...as well as adding additional exports required here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling ResizeBuffers with BufferCount = 0 means that the original buffer count should be preserved.
Currently this does actually set the game buffer count to zero, causing crashes on subsequent GetBuffer calls.