Merge pull request #454 from crud89/master

adam-sawicki-a · web-flow · commit 5a53a198945b · 2024-12-02T12:46:40.000+01:00
Fix ineffective error code checks.
diff --git a/include/vk_mem_alloc.h b/include/vk_mem_alloc.h
@@ -16404,7 +16404,7 @@ VMA_CALL_PRE VkResult VMA_CALL_POST vmaCreateImage(
         pImageCreateInfo,
         allocator->GetAllocationCallbacks(),
         pImage);
-    if(res >= 0)
+    if(res == VK_SUCCESS)
     {
         VmaSuballocationType suballocType = pImageCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL ?
             VMA_SUBALLOCATION_TYPE_IMAGE_OPTIMAL :
@@ -16429,14 +16429,14 @@ VMA_CALL_PRE VkResult VMA_CALL_POST vmaCreateImage(
             1, // allocationCount
             pAllocation);
 
-        if(res >= 0)
+        if(res == VK_SUCCESS)
         {
             // 3. Bind image with memory.
             if((pAllocationCreateInfo->flags & VMA_ALLOCATION_CREATE_DONT_BIND_BIT) == 0)
             {
                 res = allocator->BindImageMemory(*pAllocation, 0, *pImage, VMA_NULL);
             }
-            if(res >= 0)
+            if(res == VK_SUCCESS)
             {
                 // All steps succeeded.
                 #if VMA_STATS_STRING_ENABLED

Original file line number	Diff line number	Diff line change
`@@ -16404,7 +16404,7 @@ VMA_CALL_PRE VkResult VMA_CALL_POST vmaCreateImage(`
`16404`	`16404`	`pImageCreateInfo,`
`16405`	`16405`	`allocator->GetAllocationCallbacks(),`
`16406`	`16406`	`pImage);`
`16407`		`- if(res >= 0)`
	`16407`	`+ if(res == VK_SUCCESS)`
`16408`	`16408`	`{`
`16409`	`16409`	`VmaSuballocationType suballocType = pImageCreateInfo->tiling == VK_IMAGE_TILING_OPTIMAL ?`
`16410`	`16410`	`VMA_SUBALLOCATION_TYPE_IMAGE_OPTIMAL :`
`@@ -16429,14 +16429,14 @@ VMA_CALL_PRE VkResult VMA_CALL_POST vmaCreateImage(`
`16429`	`16429`	`1, // allocationCount`
`16430`	`16430`	`pAllocation);`
`16431`	`16431`
`16432`		`- if(res >= 0)`
	`16432`	`+ if(res == VK_SUCCESS)`
`16433`	`16433`	`{`
`16434`	`16434`	`// 3. Bind image with memory.`
`16435`	`16435`	`if((pAllocationCreateInfo->flags & VMA_ALLOCATION_CREATE_DONT_BIND_BIT) == 0)`
`16436`	`16436`	`{`
`16437`	`16437`	`res = allocator->BindImageMemory(pAllocation, 0, pImage, VMA_NULL);`
`16438`	`16438`	`}`
`16439`		`- if(res >= 0)`
	`16439`	`+ if(res == VK_SUCCESS)`
`16440`	`16440`	`{`
`16441`	`16441`	`// All steps succeeded.`
`16442`	`16442`	`#if VMA_STATS_STRING_ENABLED`