Add workflow for static code analysis using clang-tidy#482
Add workflow for static code analysis using clang-tidy#482adam-sawicki-a merged 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom IAmNotHanni:master
Conversation
bcd776c
into
GPUOpen-LibrariesAndSDKs:master
|
Thank you for this contribution. I made some fixes in the code based on the warnings found. For the rest of the warnings, I think we can just leave them as-is and ignore them. Warnings that I consider the worst and worth disabling are:
Why shouldn't we use standard C++ headers? Is it something LLVM-specific? We are not compiling LLVM here. Likely the same with llvmlibc-callee-namespace. modernize-use-nodiscard: VMA declares compatibility with C++14, so we shouldn't have a warning about the usage of
What is this about? Something specific to Altera platform? Adding
Adding dependency on Boost is not a good idea, while Besides this, why do we have warnings about file /home/runner/work/VulkanMemoryAllocator/VulkanMemoryAllocator/build/CMakeFiles/3.31.6/CompilerIdCXX/CMakeCXXCompilerId.cpp? Why it also gets analyzed? |
-modernize-use-trailing-return-type,cppcoreguidelines-macro-usage,modernize-use-autoclang-tidy is very powerful, but it needs proper configuration because you sometimes disagree with some things it comes up with. Let me know if you have further warnings to add to the ignore list. Still, I find it interesting what it already can find.