Add a mip level filter in Memory leak finder

Author: yifeidong

source/frontend/models/compare/memory_leak_finder_model.cpp

@@ -250,16 +250,31 @@ namespace rmv
         UpdateLabels();
     }
 
+    void MemoryLeakFinderModel::FilterByMipLevelChanged(int min_value, int max_value)
+    {
+        const uint64_t scaled_min = rmv_util::CalculateThresholdFromStepValue(min_value, rmv::kMipSliderRange - 1);
+        const uint64_t scaled_max = rmv_util::CalculateThresholdFromStepValue(max_value, rmv::kMipSliderRange - 1);
+
+        proxy_model_->SetMipLevelFilter(scaled_min, scaled_max);
+        proxy_model_->invalidate();
+
+        UpdateLabels();
+    }
+
     void MemoryLeakFinderModel::UpdatePreferredHeapList(const QString& preferred_heap_filter)
     {
         proxy_model_->SetPreferredHeapFilter(preferred_heap_filter);
         proxy_model_->invalidate();
+
+        UpdateLabels();
     }
 
     void MemoryLeakFinderModel::UpdateResourceUsageList(const QString& resource_usage_filter)
     {
         proxy_model_->SetResourceUsageFilter(resource_usage_filter);
         proxy_model_->invalidate();
+
+        UpdateLabels();
     }
 
     MemoryLeakFinderProxyModel* MemoryLeakFinderModel::GetResourceProxyModel() const

source/frontend/models/compare/memory_leak_finder_model.h

@@ -84,6 +84,12 @@ namespace rmv
         /// @param [in] max_value Maximum value of slider span.
         void FilterBySizeChanged(int min_value, int max_value);
 
+        /// @brief Handle what happens when user changes the 'filter by mip level' slider.
+        ///
+        /// @param [in] min_value Minimum value of slider span.
+        /// @param [in] max_value Maximum value of slider span.
+        void FilterByMipLevelChanged(int min_value, int max_value);
+
         /// @brief Update the list of heaps selected. This is set up from the preferred heap combo box.
         ///
         /// @param [in] preferred_heap_filter The regular expression string of selected heaps.

source/frontend/views/compare/memory_leak_finder_pane.cpp

@@ -63,6 +63,7 @@ MemoryLeakFinderPane::MemoryLeakFinderPane(QWidget* parent)
 
     rmv::widget_util::InitCommonFilteringComponents(ui_->search_box_, ui_->size_slider_);
     rmv::widget_util::InitRangeSlider(ui_->size_slider_);
+    rmv::widget_util::InitRangeSlider(ui_->mip_slider_);
 
     ui_->base_allocations_checkbox_->Initialize(false, rmv::RMVSettings::Get().GetColorSnapshotViewed(), Qt::black);
     ui_->both_allocations_checkbox_->Initialize(
@@ -72,6 +73,7 @@ MemoryLeakFinderPane::MemoryLeakFinderPane(QWidget* parent)
     CompareFilterChanged();
 
     connect(ui_->size_slider_, &DoubleSliderWidget::SpanChanged, this, &MemoryLeakFinderPane::FilterBySizeSliderChanged);
+    connect(ui_->mip_slider_, &DoubleSliderWidget::SpanChanged, this, &MemoryLeakFinderPane::FilterByMipLevelSliderChanged);
     connect(ui_->search_box_, &QLineEdit::textChanged, this, &MemoryLeakFinderPane::SearchBoxChanged);
     connect(ui_->resource_table_view_, &QTableView::doubleClicked, this, &MemoryLeakFinderPane::TableDoubleClicked);
     connect(ui_->both_allocations_checkbox_, &RMVColoredCheckbox::Clicked, this, &MemoryLeakFinderPane::CompareFilterChanged);
@@ -170,6 +172,8 @@ void MemoryLeakFinderPane::Reset()
 
     ui_->size_slider_->SetLowerValue(0);
     ui_->size_slider_->SetUpperValue(ui_->size_slider_->maximum());
+    ui_->mip_slider_->SetLowerValue(ui_->mip_slider_->minimum());
+    ui_->mip_slider_->SetUpperValue(ui_->mip_slider_->maximum());
     ui_->search_box_->setText("");
 }
 
@@ -191,6 +195,12 @@ void MemoryLeakFinderPane::FilterBySizeSliderChanged(int min_value, int max_valu
     SetMaximumResourceTableHeight();
 }
 
+void MemoryLeakFinderPane::FilterByMipLevelSliderChanged(int min_value, int max_value)
+{
+    model_->FilterByMipLevelChanged(min_value, max_value);
+    SetMaximumResourceTableHeight();
+}
+
 void MemoryLeakFinderPane::CompareFilterChanged()
 {
     rmv::SnapshotCompareId filter = GetCompareIdFilter();

source/frontend/views/compare/memory_leak_finder_pane.h

@@ -59,6 +59,12 @@ private slots:
     /// @param [in] max_value Maximum value of slider span.
     void FilterBySizeSliderChanged(int min_value, int max_value);
 
+    /// @brief Slot to handle what happens when the 'filter by mip level' slider changes.
+    ///
+    /// @param [in] min_value Minimum value of slider span.
+    /// @param [in] max_value Maximum value of slider span.
+    void FilterByMipLevelSliderChanged(int min_value, int max_value);
+
     /// @brief Checkboxes on the top were clicked.
     void CompareFilterChanged();
 

source/frontend/views/compare/memory_leak_finder_pane.ui

@@ -351,6 +351,29 @@
             </property>
            </widget>
           </item>
+          <item>
+           <widget class="ScaledLabel" name="label_6_">
+            <property name="sizePolicy">
+             <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
+              <horstretch>0</horstretch>
+              <verstretch>0</verstretch>
+             </sizepolicy>
+            </property>
+            <property name="text">
+             <string>Filter by mip level:</string>
+            </property>
+           </widget>
+          </item>
+          <item>
+           <widget class="RmvRangeSlider" name="mip_slider_">
+            <property name="orientation">
+             <enum>Qt::Horizontal</enum>
+            </property>
+            <property name="SliderType">
+             <enum>ESliderType::MipLevel</enum>
+            </property>
+           </widget>
+          </item>
           <item>
            <spacer name="horizontal_spacer_2_">
             <property name="orientation">

source/frontend/views/custom_widgets/rmv_range_slider.h

@@ -24,7 +24,7 @@ enum class ESliderType : int8_t
 /// @brief Range slider that extends the double slider widget by adding a range value label.
 class RmvRangeSlider : public DoubleSliderWidget
 {
-    Q_PROPERTY(int SliderType READ SliderType WRITE setSliderType)
+    Q_PROPERTY(ESliderType SliderType READ SliderType WRITE setSliderType)
 public:
     /// @brief Constructor
     ///