This repository was archived by the owner on Aug 21, 2025. It is now read-only.
compile domain regex only once#126
Closed
elijah-wright wants to merge 1 commit into
Closed
Conversation
elijah-wright
force-pushed
the
domain-regex
branch
3 times, most recently
from
01bc154 to
97ddc0b
Compare
zjrgov
approved these changes
Jul 14, 2025
zjrgov
left a comment
zjrgov
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you for the contribution! Would you like to rebase your branch onto updated main?
elijah-wright
force-pushed
the
domain-regex
branch
from
97ddc0b to
18a2cb3
Compare
elijah-wright
force-pushed
the
domain-regex
branch
from
18a2cb3 to
1cd2398
Compare
Contributor
Author
|
ok done 👍 |
Contributor
|
@elijah-wright thanks for your contribution. I've cherry-picked your commit and opened #139 so that our actions can run and we can merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
this PR moves the regex in
processImageoutside of the function, which should reduce the amount of compilations per each service. testing from someone with cloud.gov access is definitely needed, but I benchmarked the external invocation at832.2 ns/opvs.12893 ns/opfor the existing code on a Ryzen 5 2600