Go CFD: SSH, Map Route, Integration Test Setup & Teardown#133
Conversation
pauldoomgov
left a comment
pauldoomgov
left a comment
There was a problem hiding this comment.
This looks good to go! I had one very trivial question you can feel free to ignore.
zjrgov
force-pushed
the
zjr/ssh-map_route-int_setup
branch
from
dc82543 to
cdca98e
Compare
| epCfg.ProxyHostSSH, epCfg.ProxyPortSSH, epCfg.ProxyAuthFile, | ||
| ) | ||
| args = append(args, proxy) | ||
| } |
There was a problem hiding this comment.
[question] does this ssh command not pick up the config from .ssh/ssh_config that .profile sets up?
There was a problem hiding this comment.
That's an excellent question, and I think… maybe? I will check.
There was a problem hiding this comment.
On second thought, this will take a little time to check—how do you feel about leaving it an issue for now?
I'm also not sure what exact bash stuff will be running with this gets put into use, and in any case it will be very easy to check once we've gotten there.
There was a problem hiding this comment.
I'm fine with leaving it as something to return to
zjrgov
force-pushed
the
zjr/ssh-map_route-int_setup
branch
from
e3f2aa3 to
84928e8
Compare
We use the Job ID in our containerID value, and the Job ID will be unique for every job run, so there should never be a circumstance where an existing app will be found. If it didn't hurt to check I would keep this, but the call to cloud.gov is a waste.
This fixes some frustrating tooling issues I was having because the Go root and the Git root were in different places, non-standard for Go.
…and an integration test for it!
zjrgov
force-pushed
the
zjr/ssh-map_route-int_setup
branch
from
84928e8 to
cc91626
Compare
3 participants
🎫 Addresses issue: https://github.com/GSA-TTS/devtools-program/issues/204
This includes the development of various chunks of work on the way to completing the Prepare step.
🛠 Summary of changes
✨ Special Notes
.lazy.lua) that I can ignore if preferred (not sure why I committed it?)(cfd)scope in my commit messages to disambiguate, but can remove if it's unhelpful or distracting