Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

Ensure spaces exist before creating creds services#135

Merged
rahearn merged 1 commit into
mainfrom
cups-depends-on
Jul 10, 2025
Merged

Ensure spaces exist before creating creds services#135
rahearn merged 1 commit into
mainfrom
cups-depends-on

Conversation

@rahearn

@rahearn rahearn commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

🎫 Addresses issue: no issue

🛠 Summary of changes

  • ensures the space and space roles have been fully created before attempting to create the user-provided credential services
  • this is probably only a problem with the weird way I just ran it, where I manually deleted the worker space after a bunch of PRESERVE_WORKER runs, and then tried to recreate just that space, but it's nice to fix for that case too

@rahearn rahearn requested a review from a team July 10, 2025 17:30
@rahearn rahearn self-assigned this Jul 10, 2025
@rahearn rahearn merged commit 3edb4bd into main Jul 10, 2025
6 checks passed
@rahearn rahearn deleted the cups-depends-on branch July 10, 2025 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zjrgov zjrgov zjrgov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rahearn rahearn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rahearn @zjrgov