DIGITAL-725 - small fixes/enhancements for the download_backup, and s3 credentials scripts#418
Open
arpage wants to merge 5 commits into
Open
DIGITAL-725 - small fixes/enhancements for the download_backup, and s3 credentials scripts#418arpage wants to merge 5 commits into
arpage wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
DIGITAL-725
Purpose
Small fixes and enhancements
set -ein order to specifically handle errors, rather than have an uncontrolled exit).cloud-gov-s3-cred.shinstead of polling CF for the informationDeployment and testing
The actions are untested as of now - once this is deployed to github actions, we can create a new ticket for testing and enhancing the dev backup and restore actions.
Local Setup
You do not need to have the site built locally to test this PR. Just have this branch pulled and up to date:
feature/DIGITAL-725-db-backup-scriptsQA/Testing instructions
To test the download_backup.sh script (which implicitly tests the s3 credentials script),
You should end up with the latest backup file from dev (as of now dated March 10).
Checklist for the Developer
Checklist for the Peer Reviewers