Merge "Make BGS and Giant's Knife Advancement Items for Logic Consideration" (OoTRandomizer#2475)

Author: fenhl

Hints.py

@@ -1181,7 +1181,6 @@ def get_important_check_hint(spoiler: Spoiler, world: World, checked: dict[HintA
                 and not location.item.name == 'Triforce Piece'
                 and not (location.name == 'Song from Impa' and 'Zeldas Letter' in world.settings.starting_items and 'Zeldas Letter' not in world.settings.shuffle_child_trade)
                 # Special cases where the item is only considered major for important checks hints
-                or location.item.name == 'Biggoron Sword'
                 or location.item.name == 'Double Defense'
                 # Handle make keys not in own dungeon major items
                 or (location.item.type in ('SmallKey', 'SmallKeyRing') and not (world.settings.shuffle_smallkeys == 'dungeon' or world.settings.shuffle_smallkeys == 'vanilla'))

ItemList.py

@@ -363,7 +363,7 @@ class GetItemId(IntEnum):
     'Eyedrops':                                        ('Item',     True,  GetItemId.GI_EYE_DROPS, {'trade': True}),
     'Claim Check':                                     ('Item',     True,  GetItemId.GI_CLAIM_CHECK, {'trade': True}),
     'Kokiri Sword':                                    ('Item',     True,  GetItemId.GI_SWORD_KOKIRI, None),
-    'Giants Knife':                                    ('Item',     None,  GetItemId.GI_SWORD_KNIFE, None),
+    'Giants Knife':                                    ('Item',     True,  GetItemId.GI_SWORD_KNIFE, None),
     'Deku Shield':                                     ('Item',     None,  GetItemId.GI_SHIELD_DEKU, None),
     'Hylian Shield':                                   ('Item',     None,  GetItemId.GI_SHIELD_HYLIAN, None),
     'Mirror Shield':                                   ('Item',     True,  GetItemId.GI_SHIELD_MIRROR, None),
@@ -394,7 +394,7 @@ class GetItemId(IntEnum):
     'Gerudo Mask':                                     ('Item',     None,  GetItemId.GI_MASK_GERUDO, {'trade': True, 'object': 0x0152}),
     'Rupees (50)':                                     ('Item',     None,  GetItemId.GI_RUPEE_PURPLE, {'junk': 1}),
     'Rupees (200)':                                    ('Item',     None,  GetItemId.GI_RUPEE_GOLD, {'junk': 0}),
-    'Biggoron Sword':                                  ('Item',     None,  GetItemId.GI_SWORD_BIGGORON, None),
+    'Biggoron Sword':                                  ('Item',     True,  GetItemId.GI_SWORD_BIGGORON, None),
     'Fire Arrows':                                     ('Item',     True,  GetItemId.GI_ARROW_FIRE, None),
     'Ice Arrows':                                      ('Item',     True,  GetItemId.GI_ARROW_ICE, None),
     'Blue Fire Arrows':                                ('Item',     True,  GetItemId.GI_ARROW_ICE, None),

version.py

@@ -1,4 +1,4 @@
-__version__ = '8.3.63'
+__version__ = '8.3.64'
 
 # This is a supplemental version number for branches based off of main dev.
 supplementary_version = 0