Merge 'Add CI check to ensure no presets are password-locked' (OoTRandomizer#2386)

Author: fenhl

CI.py

@@ -114,12 +114,15 @@ def check_hell_mode_tricks(fix_errors: bool = False) -> None:
             print(file=file)
 
 
-def check_preset_spoilers(fix_errors: bool = False) -> None:
-    # Check to make sure spoiler logs are enabled for all presets.
+def check_preset_settings(fix_errors: bool = False) -> None:
+    # Check to make sure password lock is disabled and spoiler logs are enabled for all presets.
     with open(data_path('presets_default.json'), encoding='utf-8') as f:
         presets = json.load(f)
 
     for preset_name, preset in presets.items():
+        if preset['password_lock']:
+            error(f'{preset_name} preset is password-locked', True)
+            preset['password_lock'] = False
         if not preset['create_spoiler']:
             error(f'{preset_name} preset does not create spoiler logs', True)
             preset['create_spoiler'] = True
@@ -259,7 +262,7 @@ def run_ci_checks() -> NoReturn:
         check_code_style(args.fix)
         check_presets_formatting(args.fix)
         check_table_sizes()
-        check_preset_spoilers(args.fix)
+        check_preset_settings(args.fix)
         check_message_duplicates()
 
     exit_ci(args.fix)

version.py

@@ -1,4 +1,4 @@
-__version__ = '8.3.48'
+__version__ = '8.3.49'
 
 # This is a supplemental version number for branches based off of main dev.
 supplementary_version = 0