Skip to content

Commit 3765678

Browse files
committed
fix: drop typescript-eslint 'project' (superseded by projectService)
typescript-eslint v8 errors when both options are set. Also moves the kitchen-sink ScrollView import to react-native (gesture-handler ScrollView was flagged by no-restricted-syntax), and applies prettier to the new .maestro/README.md.
1 parent 657db8d commit 3765678

3 files changed

Lines changed: 18 additions & 10 deletions

File tree

examples/kitchen-sink/.maestro/README.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,28 +7,29 @@ app, executed with [Maestro](https://maestro.mobile.dev).
77

88
### Run on CI (`.github/workflows/e2e-ios.yml`)
99

10-
| File | Purpose |
11-
| ---- | ------- |
12-
| `smoke-launch.yaml` | App boots and the home screen renders the primary buttons. |
10+
| File | Purpose |
11+
| ----------------------------- | ------------------------------------------------------------------------------------------------------------------- |
12+
| `smoke-launch.yaml` | App boots and the home screen renders the primary buttons. |
1313
| `smoke-modal-open-close.yaml` | The primary "Show Modal" example opens `ExampleModal` and can be dismissed via the in-modal **Close Modal** button. |
1414

1515
These flows only touch UI surfaces that exist on the `renovate-sweep` /
1616
`main` branches and should be stable across SDK upgrades.
1717

1818
### Present but NOT in the CI matrix
1919

20-
| File | Why it is skipped |
21-
| ---- | ----- |
20+
| File | Why it is skipped |
21+
| -------------------------- | ------------------------------------------------------------------------------------------------------------------------- |
2222
| `crash-test-dropdown.yaml` | References `app/crash-test.tsx` ("Android Crash Test (Pure Reproduction)") which only exists on the issue-155 fix branch. |
23-
| `issue155-crash-test.yaml` | References `app/issue155.tsx` ("Test Issue #155 (Navigation Crash)") which only exists on the issue-155 fix branch. |
24-
| `stress-test-crash.yaml` | Same as above — depends on the crash-test screen. |
23+
| `issue155-crash-test.yaml` | References `app/issue155.tsx` ("Test Issue #155 (Navigation Crash)") which only exists on the issue-155 fix branch. |
24+
| `stress-test-crash.yaml` | Same as above — depends on the crash-test screen. |
2525

2626
Once the issue-155 fix branch is merged (which adds the `crash-test` and
2727
`issue155` route files), add these flows to the `e2e-ios.yml` matrix.
2828

2929
## Run locally
3030

3131
Prereqs:
32+
3233
- macOS with Xcode + an iOS simulator booted.
3334
- The kitchen-sink app installed on the simulator:
3435
```sh
@@ -39,11 +40,13 @@ Prereqs:
3940
- Maestro CLI: <https://maestro.mobile.dev/getting-started/installing-maestro>.
4041

4142
Run a single flow:
43+
4244
```sh
4345
maestro test examples/kitchen-sink/.maestro/smoke-launch.yaml
4446
```
4547

4648
Run the CI smoke set:
49+
4750
```sh
4851
maestro test \
4952
examples/kitchen-sink/.maestro/smoke-launch.yaml \

examples/kitchen-sink/src/app/index.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
11
/* eslint-disable react-native/no-color-literals */
22
import type { Direction } from "react-native-magic-modal";
33
import React from "react";
4-
import { Platform, Pressable, StyleSheet, Text } from "react-native";
5-
import { ScrollView } from "react-native-gesture-handler";
4+
import {
5+
Platform,
6+
Pressable,
7+
ScrollView,
8+
StyleSheet,
9+
Text,
10+
} from "react-native";
611
import { magicModal, MagicModalHideReason } from "react-native-magic-modal";
712
import { ZoomIn, ZoomOut } from "react-native-reanimated";
813
import { router } from "expo-router";

packages/eslint-config/base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const baseConfig = tseslint.config(
5656
languageOptions: {
5757
parser,
5858
parserOptions: {
59-
project: true,
59+
projectService: true,
6060
},
6161
globals: {
6262
...globals.node,

0 commit comments

Comments
 (0)