Skip to content

Commit 3e46229

Browse files
committed
fix(ci): scope release to magic-modal, fix docs --force, pin Xcode 26
Three post-merge regressions from #161: 1. The 🚀 Publish workflow failed because turbo release fanned out to both packages/modal and packages/eslint-config; the eslint-config attempted npm publish without auth. Scope the workspace release script to react-native-magic-modal only. 2. The 📚 Docs workflow failed on `pnpm run docs --force` because the current turbo version doesn't accept --force without `--`. 3. The 📱 E2E iOS workflow failed because macos-15's default Xcode 16.4 (Swift 6.0) can't parse expo-modules-core 55.x's `@MainActor` extension syntax. Pin Xcode 26 (Swift 6.1+) before the build step. After this lands, manually re-trigger the Publish workflow on main to ship react-native-magic-modal@7.0.0 to npm.
1 parent eaf8aec commit 3e46229

3 files changed

Lines changed: 15 additions & 2 deletions

File tree

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171
uses: actions/configure-pages@v5
7272

7373
- name: 📚 Generate Docs
74-
run: pnpm run docs --force
74+
run: pnpm run docs -- --force
7575

7676
- name: 📩 Upload artifact
7777
uses: actions/upload-pages-artifact@v3

.github/workflows/e2e-ios.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,19 @@ jobs:
2424
- name: 🏗 Setup Repo
2525
uses: actions/checkout@v4
2626

27+
- name: 🏗 Select Xcode 26 (Swift 6.1+ for expo-modules-core)
28+
run: |
29+
# expo-modules-core 55.x uses @MainActor extension syntax (Swift 6.1+).
30+
# macos-15 default is Xcode 16.4 (Swift 6.0) which can't parse it.
31+
XCODE_PATH=$(ls -d /Applications/Xcode_26*.app 2>/dev/null | head -1)
32+
if [ -z "$XCODE_PATH" ]; then
33+
echo "No Xcode 26 found; falling back to default. Pods may not compile."
34+
xcodebuild -version
35+
else
36+
sudo xcode-select -s "$XCODE_PATH/Contents/Developer"
37+
xcodebuild -version
38+
fi
39+
2740
- name: 🏗 Setup PNPM
2841
uses: pnpm/action-setup@v4
2942

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"start": "turbo start",
3131
"test": "turbo test",
3232
"build": "turbo build",
33-
"release": "turbo release",
33+
"release": "turbo run release --filter=react-native-magic-modal",
3434
"docs": "turbo docs",
3535
"doctor": "turbo doctor"
3636
},

0 commit comments

Comments
 (0)