Skip to content

Commit 8b3d80e

Browse files
committed
fix attempt
1 parent 4e99b13 commit 8b3d80e

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"format": "turbo format",
2828
"format:fix": "turbo format:fix",
2929
"typecheck": "turbo typecheck",
30-
"start": "turbo start",
30+
"start": "pnpm --filter @magic/kitchen-sink start",
3131
"test": "turbo test",
3232
"build": "turbo build",
3333
"release": "turbo release",

packages/modal/src/components/MagicModalPortal/MagicModalPortal.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,12 @@ export const MagicModalPortal: React.FC = memo(() => {
188188
});
189189
}, [modals]);
190190

191-
const Overlay =
192-
fullWindowOverlayEnabled && Platform.OS === "ios"
193-
? FullWindowOverlay
194-
: React.Fragment;
191+
const shouldRenderFullWindowOverlay =
192+
fullWindowOverlayEnabled && Platform.OS === "ios" && modals.length > 0;
193+
194+
const Overlay = shouldRenderFullWindowOverlay
195+
? FullWindowOverlay
196+
: React.Fragment;
195197

196198
/* This needs to always be rendered, if we make it conditionally render based on ModalContent too,
197199
the modal will have zIndex issues on react-navigation modals. */

0 commit comments

Comments
 (0)