Skip to content

feat(eslint): publish eslint package#140

Merged
GSTJ merged 34 commits into
mainfrom
feat/split-eslint
Jun 6, 2025
Merged

feat(eslint): publish eslint package#140
GSTJ merged 34 commits into
mainfrom
feat/split-eslint

Conversation

@GSTJ
Copy link
Copy Markdown
Owner

@GSTJ GSTJ commented Jun 5, 2025

No description provided.

@GSTJ GSTJ changed the title feat: split react native package feat: split eslint package Jun 5, 2025
@GSTJ GSTJ changed the title feat: split eslint package feat(eslint): publish eslint package Jun 5, 2025
@GSTJ GSTJ requested a review from Copilot June 5, 2025 23:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on publishing the ESLint package while updating and modernizing several configurations and code files. Key changes include the removal of disabled test files and snapshot files, refactoring of style constants, and conversion of configuration files to ES module syntax.

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/modal/src/components/MagicModalPortal/MagicModalPortal.test-disabled.tsx Disabled test file removed
packages/modal/src/components/MagicModalPortal/MagicModalPortal.styles.ts Introduced BACKDROP_COLOR constant
packages/modal/src/components/MagicModal.tsx Updated onBackdropPress handler and dependency list
packages/modal/snapshots/MagicModalPortal.test.tsx.snap Removed snapshot file
packages/modal/package.json Removed inline eslintConfig from package.json
packages/modal/jest.config.js Converted to export default ES module syntax
packages/modal/eslint.config.js, babel.config.js Added new ESM configuration files
packages/modal/babel.config.cjs Removed legacy babel config file
packages/modal/.release-it.js Added commit filter for modal commits
examples/* Various adjustments across tsconfig, app config, babel, metro, and eslint config files
Comments suppressed due to low confidence (1)

packages/modal/src/components/MagicModalPortal/MagicModalPortal.test-disabled.tsx:1

  • The removal of the disabled test file could impact overall test coverage; please confirm that these tests are no longer necessary or that adequate coverage is provided elsewhere.
import React from "react";

Comment thread packages/modal/src/components/MagicModal.tsx
@GSTJ GSTJ merged commit 3595a63 into main Jun 6, 2025
1 check passed
ssukru pushed a commit to ssukru/react-native-magic-modal that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants