feat(eslint): publish eslint package#140
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on publishing the ESLint package while updating and modernizing several configurations and code files. Key changes include the removal of disabled test files and snapshot files, refactoring of style constants, and conversion of configuration files to ES module syntax.
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/modal/src/components/MagicModalPortal/MagicModalPortal.test-disabled.tsx | Disabled test file removed |
| packages/modal/src/components/MagicModalPortal/MagicModalPortal.styles.ts | Introduced BACKDROP_COLOR constant |
| packages/modal/src/components/MagicModal.tsx | Updated onBackdropPress handler and dependency list |
| packages/modal/snapshots/MagicModalPortal.test.tsx.snap | Removed snapshot file |
| packages/modal/package.json | Removed inline eslintConfig from package.json |
| packages/modal/jest.config.js | Converted to export default ES module syntax |
| packages/modal/eslint.config.js, babel.config.js | Added new ESM configuration files |
| packages/modal/babel.config.cjs | Removed legacy babel config file |
| packages/modal/.release-it.js | Added commit filter for modal commits |
| examples/* | Various adjustments across tsconfig, app config, babel, metro, and eslint config files |
Comments suppressed due to low confidence (1)
packages/modal/src/components/MagicModalPortal/MagicModalPortal.test-disabled.tsx:1
- The removal of the disabled test file could impact overall test coverage; please confirm that these tests are no longer necessary or that adequate coverage is provided elsewhere.
import React from "react";
ssukru
pushed a commit
to ssukru/react-native-magic-modal
that referenced
this pull request
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.