Skip to content

Fix NPE from map corruption when sync handlers register entries during init #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Luca-Guettinger wants to merge 1 commit into from
Closed

Fix NPE from map corruption when sync handlers register entries during init #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/com/cleanroommc/modularui/value/sync/PanelSyncManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,13 @@ public PanelSyncManager(ModularSyncManager msm, boolean main) {
@ApiStatus.Internal
public void initialize(String panelName) {
this.panelName = panelName;
this.syncHandlers.forEach((mapKey, syncHandler) -> syncHandler.init(mapKey, this));
var snapshotKeys = new ArrayList<>(this.syncHandlers.keySet());
for (var mapKey : snapshotKeys) {
var syncHandler = this.syncHandlers.get(mapKey);
if (syncHandler != null) {
syncHandler.init(mapKey, this);
}
}
this.locked = true;
this.init = true;
this.subPanels.forEach((s, syncHandler) -> this.modularSyncManager.getMainPSM().registerPanelSyncHandler(s, syncHandler));
Expand Down