Textfield number input fixes.#131
Merged
Merged
Conversation
…and backspace, add comma and underscore to characters that are included when holding ctrl,
7 tasks
Miklebe
approved these changes
May 31, 2026
Miklebe
left a comment
There was a problem hiding this comment.
Looked through the code, seems good. I am not the most knowledgeable guy, but so far seems like working fix and a few extra changes to add a bit more keybinds for text fields. Tested in GT5 dev env, saw no problems after changing to the new methods. ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made expression behaviour more similar to GTNHLib's parser for whole numbers, that is:
Unfortunatly the way parsing works, we can't detect if % was actually used. Instead the maximum value is multiplied if the parsed number is a noninteger (
Math.abs(value - rounded) < 0.0000001).Additionally, I adjusted the scrolling logic to allow multiple modifiers to be active at the same time and added scroll step for ALT.
I also added a text field test to TestGuis (open with diamond).