Fix crash in PanelSyncHandler and TextFieldHandler#133
Merged
brachy84 merged 2 commits intoJun 1, 2026
Conversation
brachy84
approved these changes
Jun 1, 2026
brachy84
deleted the
fix/Fix-crash-in-PanelSyncHandler-and-TextFieldHandler
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "IllegalStateException: Sync handler is not yet initialised!" in PanelSyncHandler.closePanelInternal() when closing a GUI during a mouse press event. The root cause is a timing issue: ModularNetwork.CLIENT.closeAll() disposes sync handlers immediately while PanelManager.dispose() is deferred by cantDisposeNow, so by the time deferred disposal finalizes panels, their sync handlers are already dead. The fix makes closePanelInternal skip sync operations when the sync infrastructure is already torn down.
Fix StringIndexOutOfBoundsException in TextFieldHandler.insert() when cursor.x exceeds the current line length, by clamping the cursor position to the line bounds before substring operations.
Tested on server