Skip to content

Commit 11c473b

Browse files
committed
fix: raise errors for invalid shears
1 parent a5afbf5 commit 11c473b

3 files changed

Lines changed: 11 additions & 18 deletions

File tree

tests/galsim_test_helpers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# and/or other materials provided with the distribution.
1717
#
1818

19+
import equinox
1920
import pytest
2021
import numpy as np
2122
import galsim
@@ -52,6 +53,7 @@
5253
"pytest",
5354
"run_slow",
5455
"runtests",
56+
"equinox",
5557
]
5658

5759
# This file has some helper functions that are used by tests from multiple files to help

tests/test_shear.py

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -176,23 +176,17 @@ def test_shear_initialization():
176176
assert_raises(TypeError,galsim.Shear,g1=0.3,e2=0.2)
177177
assert_raises(TypeError,galsim.Shear,eta1=0.3,beta=0.*galsim.degrees)
178178
assert_raises(TypeError,galsim.Shear,q=0.3)
179-
if is_jax_galsim():
180-
pass
181-
else:
182-
assert_raises(galsim.GalSimRangeError,galsim.Shear,q=1.3,beta=0.*galsim.degrees)
183-
assert_raises(galsim.GalSimRangeError,galsim.Shear,g1=0.9,g2=0.6)
184-
assert_raises(galsim.GalSimRangeError,galsim.Shear,e=-1.3,beta=0.*galsim.radians)
185-
assert_raises(galsim.GalSimRangeError,galsim.Shear,e=1.3,beta=0.*galsim.radians)
186-
assert_raises(galsim.GalSimRangeError,galsim.Shear,e1=0.7,e2=0.9)
179+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,q=1.3,beta=0.*galsim.degrees)
180+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,g1=0.9,g2=0.6)
181+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,e=-1.3,beta=0.*galsim.radians)
182+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,e=1.3,beta=0.*galsim.radians)
183+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,e1=0.7,e2=0.9)
187184
assert_raises(TypeError,galsim.Shear,g=0.5)
188185
assert_raises(TypeError,galsim.Shear,e=0.5)
189186
assert_raises(TypeError,galsim.Shear,eta=0.5)
190-
if is_jax_galsim():
191-
pass
192-
else:
193-
assert_raises(galsim.GalSimRangeError,galsim.Shear,eta=-0.5,beta=0.*galsim.radians)
194-
assert_raises(galsim.GalSimRangeError,galsim.Shear,g=1.3,beta=0.*galsim.radians)
195-
assert_raises(galsim.GalSimRangeError,galsim.Shear,g=-0.3,beta=0.*galsim.radians)
187+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,eta=-0.5,beta=0.*galsim.radians)
188+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,g=1.3,beta=0.*galsim.radians)
189+
assert_raises((galsim.GalSimRangeError, equinox.EquinoxRuntimeError),galsim.Shear,g=-0.3,beta=0.*galsim.radians)
196190
assert_raises(TypeError,galsim.Shear,e=0.3,beta=0.)
197191
assert_raises(TypeError,galsim.Shear,eta=0.3,beta=0.)
198192
assert_raises(TypeError,galsim.Shear,randomkwarg=0.1)

tests/test_wcs.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1186,10 +1186,7 @@ def test_pixelscale(run_slow):
11861186
assert wcs.world_origin == galsim.PositionD(0,0)
11871187

11881188
assert_raises(TypeError, galsim.PixelScale)
1189-
if is_jax_galsim():
1190-
pass
1191-
else:
1192-
assert_raises(TypeError, galsim.PixelScale, scale=galsim.PixelScale(scale))
1189+
assert_raises(TypeError, galsim.PixelScale, scale=galsim.PixelScale(scale))
11931190
assert_raises(TypeError, galsim.PixelScale, scale=scale, origin=galsim.PositionD(0,0))
11941191
assert_raises(TypeError, galsim.PixelScale, scale=scale, world_origin=galsim.PositionD(0,0))
11951192

0 commit comments

Comments
 (0)