Skip to content

fix: phot comp is exact #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beckermr merged 1 commit into from
May 13, 2026
Merged

fix: phot comp is exact #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tests/test_exponential.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,7 @@ def test_exponential_shoot():
assert np.isclose(added_flux, obj.flux)
assert np.isclose(im.array.sum(), obj.flux)
photons2 = obj.makePhot(poisson_flux=False, rng=rng)
if is_jax_galsim():
np.testing.assert_allclose(photons2.x, photons.x)
np.testing.assert_allclose(photons2.y, photons.y)
np.testing.assert_allclose(photons2.flux, photons.flux)
else:
assert photons2 == photons, "Exponential makePhot not equivalent to drawPhot"
assert photons2 == photons, "Exponential makePhot not equivalent to drawPhot"


@timer
Expand Down
Loading