Skip to content

fix: round properly when rendering int images#238

Merged
beckermr merged 8 commits into
mainfrom
fix-rounding
May 12, 2026
Merged

fix: round properly when rendering int images#238
beckermr merged 8 commits into
mainfrom
fix-rounding

Conversation

@beckermr

Copy link
Copy Markdown
Collaborator

JAX has platform dependent rounding, so we round everything explicitly.

@codspeed-hq

codspeed-hq Bot commented May 12, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 38.31%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 4 regressed benchmarks
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_benchmarks_lanczos_interp[xval-conserve_dc-run] 126.2 µs 71.9 µs +75.61%
WallTime test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] 113.6 µs 74.2 µs +53.21%
WallTime test_benchmarks_lanczos_interp[kval-conserve_dc-run] 60.1 µs 40.9 µs +46.91%
WallTime test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] 53.4 µs 41 µs +30.34%
WallTime test_benchmark_invert_ab_noraise[run] 144.1 µs 108.7 µs +32.65%
WallTime test_benchmark_moffat_init[run] 97.1 µs 68.1 µs +42.48%
WallTime test_benchmark_spergel_conv[run] 157.6 ms 239.5 ms -34.21%
WallTime test_benchmark_moffat_conv[run] 185.8 ms 279.8 ms -33.6%
WallTime test_benchmark_spergel_xvalue[run] 1.6 s 2.5 s -38.31%
WallTime test_benchmark_moffat_conv_grad[run] 289.1 ms 440.3 ms -34.35%

Comparing fix-rounding (5b7836e) with main (6a8d05a)

Open in CodSpeed

@beckermr

Copy link
Copy Markdown
Collaborator Author

@beckermr beckermr marked this pull request as ready for review May 12, 2026 15:42
@beckermr beckermr merged commit 7b6aecc into main May 12, 2026
10 checks passed
@beckermr beckermr deleted the fix-rounding branch May 12, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant