fix: ensure bounds vmaps as best as possible, more equinox errors, types for __eq__, _BoundsD/I#250
Open
beckermr wants to merge 77 commits into
Open
fix: ensure bounds vmaps as best as possible, more equinox errors, types for __eq__, _BoundsD/I#250beckermr wants to merge 77 commits into
__eq__, _BoundsD/I#250beckermr wants to merge 77 commits into
Conversation
Merging this PR will degrade performance by 34.94%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| 👁 | Simulation | test_benchmark_invert_ab_noraise[run] |
523 µs | 803.8 µs | -34.94% |
Comparing bounds-fix-again-all-static (afe868f) with main (e2b1029)
beckermr
commented
May 20, 2026
beckermr
commented
May 20, 2026
beckermr
commented
May 20, 2026
beckermr
commented
May 20, 2026
beckermr
commented
May 20, 2026
beckermr
commented
May 22, 2026
beckermr
commented
May 22, 2026
Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
beckermr
commented
May 23, 2026
beckermr
commented
May 23, 2026
__eq____eq__, _BoundsD/I
Collaborator
Author
|
OK @ismael-mendoza this one is ready for review. I hope this is the last major bit of work on these classes for a long time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few other things with the bounds classes, images and typing.
BoundsD/Ivmaps as best as possible__eq__methods return JAX boolean values except when no values from the class are ever traced (e.g., two staticBoundsIclasses, interpolants)_BoundsD/I__eq__APIcloses #245
closes #237