🩹 fix(v0.24): validate chart component count; drop dead normalize_vector

[nstarman]

Summary

Two small robustness fixes surfaced by the v0.24 pre-release audit.

1. charts: validate component count against the declared dimension flag

Concrete AbstractFixedComponentsChart subclasses carrying an AbstractDimensionalFlag (e.g. Abstract3D, n=3) now assert their component count matches the declared dimension at class-creation time, replacing the six # TODO: add a check it's ND placeholders in d0–d6 with one central check: the flag records _chart_ndim, and AbstractFixedComponentsChart.__init_subclass__ compares it to the resolved component tuple, raising a clear TypeError on mismatch. Abstract and variable-n charts are unaffected.

2. vectors: remove the orphaned normalize_vector stub

A @plum.dispatch.abstract with no concrete registration, no public export, no callers, and no tests — dead scaffolding.

Note

Rebased onto current main (post-#571). The audit's original third item — a (K,)@(K,M) QMatrix matmul path — has been dropped, since #571 removed the entire quantity_matrix module in favor of unxts.linalg.

Verification

• New unit tests; tests/unit/charts passes; ruff clean.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR bundles three robustness fixes found during the v0.24 pre-release audit: enforcing chart dimensional consistency at class creation, removing dead vector-normalization scaffolding, and extending QMatrix matmul support to handle (K,) @ (K, M) vector–matrix multiplication with unit reconciliation.

Changes:

• Add class-creation-time validation that fixed-component charts’ component counts match any mixed-in dimensional flag (Abstract0D–Abstract6D).
• Remove the orphaned normalize_vector abstract dispatch stub from the vectors API surface.
• Implement and test (K,) @ (K, M) support in QMatrix dot_general/matmul, including unit conversions.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/unit/internal/test_quantity_matrix.py	Adds unit tests for 1D@2D QMatrix matmul behavior.
tests/unit/charts/test_base.py	Adds regression test ensuring mismatched dimensional flags/components raise TypeError.
src/coordinax/vectors/_src/api.py	Removes dead normalize_vector abstract API stub (file deleted).
src/coordinax/vectors/_src/init.py	Stops exporting the removed vectors API stub via star-import.
src/coordinax/_src/internal/quantity_matrix/_register_primitives.py	Adds _dot_general_1d_2d and routes 1D@2D through it.
src/coordinax/_src/charts/d0.py	Removes now-redundant TODO for 0D component-count validation.
src/coordinax/_src/charts/d1.py	Removes now-redundant TODO for 1D component-count validation.
src/coordinax/_src/charts/d2.py	Removes now-redundant TODO for 2D component-count validation.
src/coordinax/_src/charts/d3.py	Removes now-redundant TODO for 3D component-count validation.
src/coordinax/_src/charts/d4.py	Removes now-redundant TODO for 4D component-count validation.
src/coordinax/_src/charts/d6.py	Removes now-redundant TODO for 6D component-count validation.
src/coordinax/_src/base/charts.py	Records declared dimensionality on flags and enforces fixed-component count consistency in AbstractFixedComponentsChart.__init_subclass__.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.71%. Comparing base (4b69f2d) to head (6eca5a1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   94.58%   94.71%   +0.12%     
==========================================
  Files         247      249       +2     
  Lines        7809     7981     +172     
==========================================
+ Hits         7386     7559     +173     
+ Misses        423      422       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/coordinax/_src/base/charts.py:373

• The new ndim/components validation runs unconditionally for any non-abstract AbstractFixedComponentsChart subclass, which breaks charts without a fixed integer dimension flag (e.g., AbstractND sets _chart_ndim to "N") and can also raise TypeError via len(None) if _components isn't set. This check should only run when _chart_ndim is a fixed int and _components is available.

            ndim = getattr(cls, "_chart_ndim", None)
            if len(getattr(cls, "_components", None)) != ndim:
                msg = (
                    f"{cls.__name__} is declared {ndim}D but has "
                    f"{len(cls._components)} components {cls._components}"

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.