Add Monk vocation#48
Open
szmalcher88-ai wants to merge 1 commit into
Open
Conversation
tibiapy.enums.Vocation had no member for the Monk vocation, so a Monk / Exalted Monk character on a Char Bazaar page made try_enum(Vocation, "Monk") return None and the Auction model rejected the whole page with InvalidContentError. - Vocation: add MONK / EXALTED_MONK (+ base property maps Exalted Monk -> Monk) - AuctionVocationFilter.MONK, HighscoresProfession.MONKS, SpellVocationFilter.MONK - regression test in tests_enums.py + CHANGELOG entry Fixes Galarzaa90#47 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Monk vocation (and its promotion, Exalted Monk) to
tibiapy.enums, fixing the bazaar parse failure reported in #47.Why
Vocationhas noMONK/EXALTED_MONKmember. When a Monk is on a Char Bazaar page,try_enum(Vocation, "Monk")returnsNone, and the requiredAuction.vocationfield rejects it — so the entire page fails with:Monks are now common on the bazaar, so
fetch_current_auctions/fetch_auction_historybreak on any page containing one.Changes
Vocation: addMONK = "Monk"andEXALTED_MONK = "Exalted Monk", and mapEXALTED_MONK.base → MONK.AuctionVocationFilter.MONK,HighscoresProfession.MONKS,SpellVocationFilter.MONKfor complete vocation coverage.tests/tests_enums.py(coversVocation("Monk"),Vocation("Exalted Monk").base, and thetry_enumpath the parser actually uses).Notes
WeaponProficiencyfeature and was orphaned when its author's account was deleted — so the fix was lost rather than rejected.)__version__untouched and used a6.4.0 (unreleased)CHANGELOG header — happy to adjust the version/date to match your release process.AuctionVocationFilter.MONK = 6,HighscoresProfession.MONKS = 6) follow the existing sequential pattern (and match Add monk vocation #45); worth a quick double-check against the live forms.Testing
tests_enums.py,tests_bazaar.py,tests_character.pypass locally (28 passed). The new test fails onmainand passes with this change.Fixes #47
🤖 Generated with Claude Code